Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACM certificate: Additional attributes #26784

Merged
merged 26 commits into from
Sep 29, 2022
Merged

ACM certificate: Additional attributes #26784

merged 26 commits into from
Sep 29, 2022

Commits on Sep 12, 2022

  1. r/aws_acm_certificate: Switch to 'WithoutTimeout' CRUD handler signat… 

    …ures (#15090).
    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    84ac8b9 View commit details
    Browse the repository at this point in the history

  2. r/aws_acm_certificate_validation: Switch to 'WithoutTimeout' CRUD han… 

    …dler signatures (#15090).
    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    d8140c9 View commit details
    Browse the repository at this point in the history

  3. r/aws_acm_certificate(_validation): Pass context.

    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3fd53c0 View commit details
    Browse the repository at this point in the history

  4. d/aws_acm_certificate: Alphabetize attributes.

    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    aa92ea2 View commit details
    Browse the repository at this point in the history

  5. d/aws_acm_certificate: Switch to 'WithoutTimeout' CRUD handler signat… 

    …ures (#15090).
    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    73c15cf View commit details
    Browse the repository at this point in the history

  6. Fix 'github.com/hashicorp/terraform-plugin-sdk/v2/diag.Errorf does no… 

    …t support error-wrapping directive %w'.
    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    d39409e View commit details
    Browse the repository at this point in the history

  7. d/aws_acm_certificate: Tweaked error message.

    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3f407e9 View commit details
    Browse the repository at this point in the history

  8. % ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TESTARGS='-r… 

    …un=TestAccACMCertificate_' PKG=acm ACCTEST_PARALLELISM=1

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 1  -run=TestAccACMCertificate_ -timeout 180m
=== RUN   TestAccACMCertificate_emailValidation
=== PAUSE TestAccACMCertificate_emailValidation
=== RUN   TestAccACMCertificate_dnsValidation
=== PAUSE TestAccACMCertificate_dnsValidation
=== RUN   TestAccACMCertificate_root
=== PAUSE TestAccACMCertificate_root
=== RUN   TestAccACMCertificate_validationOptions
=== PAUSE TestAccACMCertificate_validationOptions
=== RUN   TestAccACMCertificate_privateCert
=== PAUSE TestAccACMCertificate_privateCert
=== RUN   TestAccACMCertificate_Root_trailingPeriod
=== PAUSE TestAccACMCertificate_Root_trailingPeriod
=== RUN   TestAccACMCertificate_rootAndWildcardSan
=== PAUSE TestAccACMCertificate_rootAndWildcardSan
=== RUN   TestAccACMCertificate_SubjectAlternativeNames_emptyString
=== PAUSE TestAccACMCertificate_SubjectAlternativeNames_emptyString
=== RUN   TestAccACMCertificate_San_single
=== PAUSE TestAccACMCertificate_San_single
=== RUN   TestAccACMCertificate_San_multiple
=== PAUSE TestAccACMCertificate_San_multiple
=== RUN   TestAccACMCertificate_San_trailingPeriod
=== PAUSE TestAccACMCertificate_San_trailingPeriod
=== RUN   TestAccACMCertificate_San_matches_domain
=== PAUSE TestAccACMCertificate_San_matches_domain
=== RUN   TestAccACMCertificate_wildcard
=== PAUSE TestAccACMCertificate_wildcard
=== RUN   TestAccACMCertificate_wildcardAndRootSan
=== PAUSE TestAccACMCertificate_wildcardAndRootSan
=== RUN   TestAccACMCertificate_disableCTLogging
=== PAUSE TestAccACMCertificate_disableCTLogging
=== RUN   TestAccACMCertificate_Imported_domainName
=== PAUSE TestAccACMCertificate_Imported_domainName
=== RUN   TestAccACMCertificate_Imported_validityDates
=== PAUSE TestAccACMCertificate_Imported_validityDates
=== RUN   TestAccACMCertificate_Imported_ipAddress
=== PAUSE TestAccACMCertificate_Imported_ipAddress
=== RUN   TestAccACMCertificate_PrivateKey_tags
=== PAUSE TestAccACMCertificate_PrivateKey_tags
=== CONT  TestAccACMCertificate_emailValidation
--- PASS: TestAccACMCertificate_emailValidation (28.62s)
=== CONT  TestAccACMCertificate_San_trailingPeriod
--- PASS: TestAccACMCertificate_San_trailingPeriod (25.70s)
=== CONT  TestAccACMCertificate_PrivateKey_tags
--- PASS: TestAccACMCertificate_PrivateKey_tags (52.14s)
=== CONT  TestAccACMCertificate_Imported_ipAddress
--- PASS: TestAccACMCertificate_Imported_ipAddress (17.16s)
=== CONT  TestAccACMCertificate_Imported_validityDates
--- PASS: TestAccACMCertificate_Imported_validityDates (21.23s)
=== CONT  TestAccACMCertificate_Imported_domainName
--- PASS: TestAccACMCertificate_Imported_domainName (41.05s)
=== CONT  TestAccACMCertificate_disableCTLogging
--- PASS: TestAccACMCertificate_disableCTLogging (24.55s)
=== CONT  TestAccACMCertificate_wildcardAndRootSan
--- PASS: TestAccACMCertificate_wildcardAndRootSan (22.70s)
=== CONT  TestAccACMCertificate_wildcard
--- PASS: TestAccACMCertificate_wildcard (22.48s)
=== CONT  TestAccACMCertificate_San_matches_domain
--- PASS: TestAccACMCertificate_San_matches_domain (31.43s)
=== CONT  TestAccACMCertificate_Root_trailingPeriod
--- PASS: TestAccACMCertificate_Root_trailingPeriod (1.08s)
=== CONT  TestAccACMCertificate_San_multiple
--- PASS: TestAccACMCertificate_San_multiple (29.76s)
=== CONT  TestAccACMCertificate_San_single
--- PASS: TestAccACMCertificate_San_single (27.45s)
=== CONT  TestAccACMCertificate_SubjectAlternativeNames_emptyString
--- PASS: TestAccACMCertificate_SubjectAlternativeNames_emptyString (1.03s)
=== CONT  TestAccACMCertificate_rootAndWildcardSan
--- PASS: TestAccACMCertificate_rootAndWildcardSan (23.83s)
=== CONT  TestAccACMCertificate_validationOptions
--- PASS: TestAccACMCertificate_validationOptions (25.89s)
=== CONT  TestAccACMCertificate_privateCert
--- PASS: TestAccACMCertificate_privateCert (23.22s)
=== CONT  TestAccACMCertificate_root
--- PASS: TestAccACMCertificate_root (24.48s)
=== CONT  TestAccACMCertificate_dnsValidation
--- PASS: TestAccACMCertificate_dnsValidation (26.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	474.217s
% ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TESTARGS='-run=TestAccACMCertificateValidation_' PKG=acm ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 1  -run=TestAccACMCertificateValidation_ -timeout 180m
=== RUN   TestAccACMCertificateValidation_basic
=== PAUSE TestAccACMCertificateValidation_basic
=== RUN   TestAccACMCertificateValidation_timeout
=== PAUSE TestAccACMCertificateValidation_timeout
=== RUN   TestAccACMCertificateValidation_validationRecordFQDNS
=== PAUSE TestAccACMCertificateValidation_validationRecordFQDNS
=== RUN   TestAccACMCertificateValidation_validationRecordFQDNSEmail
=== PAUSE TestAccACMCertificateValidation_validationRecordFQDNSEmail
=== RUN   TestAccACMCertificateValidation_validationRecordFQDNSRoot
=== PAUSE TestAccACMCertificateValidation_validationRecordFQDNSRoot
=== RUN   TestAccACMCertificateValidation_validationRecordFQDNSRootAndWildcard
=== PAUSE TestAccACMCertificateValidation_validationRecordFQDNSRootAndWildcard
=== RUN   TestAccACMCertificateValidation_validationRecordFQDNSSan
=== PAUSE TestAccACMCertificateValidation_validationRecordFQDNSSan
=== RUN   TestAccACMCertificateValidation_validationRecordFQDNSWildcard
=== PAUSE TestAccACMCertificateValidation_validationRecordFQDNSWildcard
=== RUN   TestAccACMCertificateValidation_validationRecordFQDNSWildcardAndRoot
=== PAUSE TestAccACMCertificateValidation_validationRecordFQDNSWildcardAndRoot
=== CONT  TestAccACMCertificateValidation_basic
--- PASS: TestAccACMCertificateValidation_basic (109.86s)
=== CONT  TestAccACMCertificateValidation_validationRecordFQDNSRootAndWildcard
--- PASS: TestAccACMCertificateValidation_validationRecordFQDNSRootAndWildcard (106.91s)
=== CONT  TestAccACMCertificateValidation_validationRecordFQDNSWildcardAndRoot
--- PASS: TestAccACMCertificateValidation_validationRecordFQDNSWildcardAndRoot (93.59s)
=== CONT  TestAccACMCertificateValidation_validationRecordFQDNSWildcard
--- PASS: TestAccACMCertificateValidation_validationRecordFQDNSWildcard (101.64s)
=== CONT  TestAccACMCertificateValidation_validationRecordFQDNSSan
--- PASS: TestAccACMCertificateValidation_validationRecordFQDNSSan (116.42s)
=== CONT  TestAccACMCertificateValidation_validationRecordFQDNSEmail
--- PASS: TestAccACMCertificateValidation_validationRecordFQDNSEmail (17.50s)
=== CONT  TestAccACMCertificateValidation_validationRecordFQDNSRoot
--- PASS: TestAccACMCertificateValidation_validationRecordFQDNSRoot (200.50s)
=== CONT  TestAccACMCertificateValidation_validationRecordFQDNS
--- PASS: TestAccACMCertificateValidation_validationRecordFQDNS (102.31s)
=== CONT  TestAccACMCertificateValidation_timeout
--- PASS: TestAccACMCertificateValidation_timeout (19.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	872.367s
    @ewbankkit
    ewbankkit committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    c39bfec View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. r/aws_acm_certificate: Add 'type' attribute. 

    Acceptance test output:

% ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TESTARGS='-run=TestAccACMCertificate_Imported_validityDates\|TestAccACMCertificate_privateCert\|TestAccACMCertificate_emailValidation\|TestAccACMCertificate_dnsValidation' PKG=acm ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 1  -run=TestAccACMCertificate_Imported_validityDates\|TestAccACMCertificate_privateCert\|TestAccACMCertificate_emailValidation\|TestAccACMCertificate_dnsValidation -timeout 180m
=== RUN   TestAccACMCertificate_emailValidation
=== PAUSE TestAccACMCertificate_emailValidation
=== RUN   TestAccACMCertificate_dnsValidation
=== PAUSE TestAccACMCertificate_dnsValidation
=== RUN   TestAccACMCertificate_privateCert
=== PAUSE TestAccACMCertificate_privateCert
=== RUN   TestAccACMCertificate_Imported_validityDates
=== PAUSE TestAccACMCertificate_Imported_validityDates
=== CONT  TestAccACMCertificate_emailValidation
--- PASS: TestAccACMCertificate_emailValidation (48.62s)
=== CONT  TestAccACMCertificate_privateCert
--- PASS: TestAccACMCertificate_privateCert (25.11s)
=== CONT  TestAccACMCertificate_Imported_validityDates
--- PASS: TestAccACMCertificate_Imported_validityDates (17.22s)
=== CONT  TestAccACMCertificate_dnsValidation
--- PASS: TestAccACMCertificate_dnsValidation (23.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	118.083s
    @ewbankkit
    ewbankkit committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    6c56cc7 View commit details
    Browse the repository at this point in the history

  2. Correct CHANGELOG entry file name.

    @ewbankkit
    ewbankkit committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a0a0f60 View commit details
    Browse the repository at this point in the history

  3. r/aws_acm_certificate: Add 'renewal_eligibility' attribute. 

    Acceptance test output:

% ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TESTARGS='-run=TestAccACMCertificate_Imported_validityDates\|TestAccACMCertificate_privateCert' PKG=acm ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 1  -run=TestAccACMCertificate_Imported_validityDates\|TestAccACMCertificate_privateCert -timeout 180m
=== RUN   TestAccACMCertificate_privateCert
=== PAUSE TestAccACMCertificate_privateCert
=== RUN   TestAccACMCertificate_Imported_validityDates
=== PAUSE TestAccACMCertificate_Imported_validityDates
=== CONT  TestAccACMCertificate_privateCert
--- PASS: TestAccACMCertificate_privateCert (25.00s)
=== CONT  TestAccACMCertificate_Imported_validityDates
--- PASS: TestAccACMCertificate_Imported_validityDates (17.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	47.285s
    @ewbankkit
    ewbankkit committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c2a9cfe View commit details
    Browse the repository at this point in the history

  4. r/aws_acm_certificate: Add 'renewal_summary' attribute. 

    Acceptance test output:

% ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TESTARGS='-run=TestAccACMCertificate_Imported_validityDates\|TestAccACMCertificate_privateCert' PKG=acm ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 1  -run=TestAccACMCertificate_Imported_validityDates\|TestAccACMCertificate_privateCert -timeout 180m
=== RUN   TestAccACMCertificate_privateCert
=== PAUSE TestAccACMCertificate_privateCert
=== RUN   TestAccACMCertificate_Imported_validityDates
=== PAUSE TestAccACMCertificate_Imported_validityDates
=== CONT  TestAccACMCertificate_privateCert
--- PASS: TestAccACMCertificate_privateCert (25.11s)
=== CONT  TestAccACMCertificate_Imported_validityDates
--- PASS: TestAccACMCertificate_Imported_validityDates (16.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	46.751s
    @ewbankkit
    ewbankkit committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    082143a View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Cleanup

    @gdavison
    gdavison committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    adc2619 View commit details
    Browse the repository at this point in the history

  2. Updates TestAccACMCertificate_privateCert to successfully issue cer… 

    …tificate and export the certificate to make in eligible for renewal
    @gdavison
    gdavison committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    ca30852 View commit details
    Browse the repository at this point in the history

  3. Uses ComposeAggregateTestCheckFunc

    @gdavison
    gdavison committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    eb0c5c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Adds check for status after certificate renewal

    @gdavison
    gdavison committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    7876ec8 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Adds tests for private certificates with and without permissions to r… 

    …enew a certificate
    @gdavison
    gdavison committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    fc990ad View commit details
    Browse the repository at this point in the history

  2. Adds renewal_status_reason for unsuccessful renewal

    @gdavison
    gdavison committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    aa7be42 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Cleanup

    @gdavison
    gdavison committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    2286819 View commit details
    Browse the repository at this point in the history

  2. Clarifies documentation

    @gdavison
    gdavison committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    ceffee1 View commit details
    Browse the repository at this point in the history

  3. Reorder tests

    @gdavison
    gdavison committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    9e1cd1f View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Adds early_renewal_duration

    @gdavison
    gdavison committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    3641e15 View commit details
    Browse the repository at this point in the history

  2. Add 'early_renewal_duration' and 'pending_renewal' to CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    f7481f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Handles renewals when modifying early_renewal_duration

    @gdavison
    gdavison committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    94e255a View commit details
    Browse the repository at this point in the history

  2. Updates docscheck make rule to be consistent with GitHub workflow. … 

    …Works around rule in ACM Certificate documentation
    @gdavison
    gdavison committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    78eec11 View commit details
    Browse the repository at this point in the history

  3. Updates URLs for ACM PCA reference documentation

    @gdavison
    gdavison committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    e9c97ec View commit details
    Browse the repository at this point in the history