-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Stack set instances operation preferences #23666
Feature: Stack set instances operation preferences #23666
Conversation
…tInstance_basic'.
…acc-test-4626730016041989152): ValidationError: You must be the master or delegated admin account of an organization before operating a SERVICE_MANAGED stack set'.
…et (tf-acc-test-4626730016041989152): ValidationError: You must be the master or delegated admin account of an organization before operating a SERVICE_MANAGED stack set'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccCloudFormationStackSetInstance_ PKG=cloudformation ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 2 -run='TestAccCloudFormationStackSetInstance_' -timeout 180m
=== RUN TestAccCloudFormationStackSetInstance_basic
=== PAUSE TestAccCloudFormationStackSetInstance_basic
=== RUN TestAccCloudFormationStackSetInstance_disappears
=== PAUSE TestAccCloudFormationStackSetInstance_disappears
=== RUN TestAccCloudFormationStackSetInstance_Disappears_stackSet
=== PAUSE TestAccCloudFormationStackSetInstance_Disappears_stackSet
=== RUN TestAccCloudFormationStackSetInstance_parameterOverrides
=== PAUSE TestAccCloudFormationStackSetInstance_parameterOverrides
=== RUN TestAccCloudFormationStackSetInstance_retainStack
=== PAUSE TestAccCloudFormationStackSetInstance_retainStack
=== RUN TestAccCloudFormationStackSetInstance_deploymentTargets
=== PAUSE TestAccCloudFormationStackSetInstance_deploymentTargets
=== RUN TestAccCloudFormationStackSetInstance_operationPreferences
=== PAUSE TestAccCloudFormationStackSetInstance_operationPreferences
=== CONT TestAccCloudFormationStackSetInstance_basic
=== CONT TestAccCloudFormationStackSetInstance_retainStack
--- PASS: TestAccCloudFormationStackSetInstance_basic (112.02s)
=== CONT TestAccCloudFormationStackSetInstance_operationPreferences
--- PASS: TestAccCloudFormationStackSetInstance_retainStack (156.55s)
=== CONT TestAccCloudFormationStackSetInstance_deploymentTargets
--- PASS: TestAccCloudFormationStackSetInstance_operationPreferences (127.95s)
=== CONT TestAccCloudFormationStackSetInstance_Disappears_stackSet
--- PASS: TestAccCloudFormationStackSetInstance_deploymentTargets (131.70s)
=== CONT TestAccCloudFormationStackSetInstance_parameterOverrides
--- PASS: TestAccCloudFormationStackSetInstance_Disappears_stackSet (107.07s)
=== CONT TestAccCloudFormationStackSetInstance_disappears
--- PASS: TestAccCloudFormationStackSetInstance_disappears (116.33s)
--- PASS: TestAccCloudFormationStackSetInstance_parameterOverrides (219.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation 510.811s
@Popsiclestick Thanks for the contribution 🎉 👏. |
@ewbankkit Thank you very much for your help improving and sorting out the testing 🙏 |
This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21307
Closes #18490
Release note:
Acceptance Tests: