Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cloudformation operation-preferences (RegionConcurrencyType, RegionOrder , FailureToleranceCount , FailureTolerancePercentage , MaxConcurrentCount , MaxConcurrentPercentage ) #21307

Closed
ashraf133 opened this issue Oct 14, 2021 · 6 comments · Fixed by #23666
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudformation Issues and PRs that pertain to the cloudformation service.

Comments

@ashraf133
Copy link

ashraf133 commented Oct 14, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

actually we can add these options to stackset deployment :

{
  "RegionConcurrencyType": "SEQUENTIAL"|"PARALLEL",
  "RegionOrder": ["string", ...],
  "FailureToleranceCount": integer,
  "FailureTolerancePercentage": integer,
  "MaxConcurrentCount": integer,
  "MaxConcurrentPercentage": integer
}

Potential Terraform Configuration

resource "aws_cloudformation_stack_set_instance" "example" {
  deployment_targets {
    organizational_unit_ids = [aws_organizations_organization.example.roots[0].id]
  }

  region         = "us-east-1"
  stack_set_name = aws_cloudformation_stack_set.example.name
  failure_tolerance_count = 1
  max_concurrent_count = 10
}

References

@ashraf133 ashraf133 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 14, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 14, 2021
@justinretzolk
Copy link
Member

Hey @ashraf133 👋 Thank you for taking the time to file this! So that we have all of the information that we need, can you update the issue description with the additional information from the feature request template?

@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 14, 2021
@ashraf133
Copy link
Author

Hello @justinretzolk Done :)

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 15, 2021
@justinretzolk justinretzolk added the service/cloudformation Issues and PRs that pertain to the cloudformation service. label Oct 15, 2021
@tikicoder
Copy link

Is this still pending information or is this waiting to be tasked?

@justinretzolk
Copy link
Member

@tikicoder at this point, I think we have the necessary information, so this is waiting to be prioritized or picked up by a community member (whichever comes first)

@ghost
Copy link

ghost commented Feb 4, 2022

I believe this is a duplicate of #18490, though I'm not sure the best way to combine them, since there are useful things in each.

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudformation Issues and PRs that pertain to the cloudformation service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants