Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Stack set instances operation preferences #23666

Merged
merged 17 commits into from
Mar 23, 2022
Merged

Feature: Stack set instances operation preferences #23666

merged 17 commits into from
Mar 23, 2022

Commits on Mar 7, 2022

  1. Initial commit for WIP PR

    @Popsiclestick
    Popsiclestick committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    4737320 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. First pass at adding some tests

    @Popsiclestick
    Popsiclestick committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    221f5c3 View commit details
    Browse the repository at this point in the history

  2. Remove default and adjust logic to update on preference changes

    @Popsiclestick
    Popsiclestick committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    6991498 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Just going to go with what works for now to move this along

    @Popsiclestick
    Popsiclestick committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    9ef1a92 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Misnamed the config name in the test

    @Popsiclestick
    Popsiclestick committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    077480c View commit details
    Browse the repository at this point in the history

  2. Updating words in the web markdown

    @Popsiclestick
    Popsiclestick committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    ac89ce0 View commit details
    Browse the repository at this point in the history

  3. Updating html markdown

    @Popsiclestick
    Popsiclestick committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    49299f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Merge branch 'main' into stack-set-instances-operation-preferences

    @Popsiclestick
    Popsiclestick committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    d6f1624 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Add CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    9c98cd1 View commit details
    Browse the repository at this point in the history

  2. Fix terrafmt error.

    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    433cddc View commit details
    Browse the repository at this point in the history

  3. Verify empty 'operation_preferences' in 'TestAccCloudFormationStackSe… 

    …tInstance_basic'.
    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    1b2cd2a View commit details
    Browse the repository at this point in the history

  4. r/aws_cloudformation_stack_set_instance: Alphabetize attributes.

    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    3815075 View commit details
    Browse the repository at this point in the history

  5. Avoid errors like 'Error: error creating CloudFormation StackSet (tf-… 

    …acc-test-4626730016041989152): ValidationError: You must be the master or delegated admin account of an organization before operating a SERVICE_MANAGED stack set'.
    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    71050ca View commit details
    Browse the repository at this point in the history

  6. Really avoid errors like 'Error: error creating CloudFormation StackS… 

    …et (tf-acc-test-4626730016041989152): ValidationError: You must be the master or delegated admin account of an organization before operating a SERVICE_MANAGED stack set'.
    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    58397f0 View commit details
    Browse the repository at this point in the history

  7. Check for service-linked role in SERVICE_MANAGED tests.

    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    b194dc1 View commit details
    Browse the repository at this point in the history

  8. Set 'deployment_targets' for 'operation_preferences'.

    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    451e3c0 View commit details
    Browse the repository at this point in the history

  9. Nudge GitHub Actions.

    @ewbankkit
    ewbankkit committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    424a374 View commit details
    Browse the repository at this point in the history