f-DeleteUnusedFMManagedResources support for aws_fms_policy resource

[CloudCally]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21294.
Closes #18037.
Closes #19961.

Output from acceptance testing:

Unable to run tests in current env.

I was able to run a plan/apply on an existing resource after building the provider and it did function as intended.
...

[zhelding]

Merging branch main to bring in line with service packages refactor done by #21306.

Confirming that in some PRs, a simple git pull origin main is sufficient to resolve merge conflicts.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[CloudCally]

Hello, @zhelding, is there anything more you need me to do to get this merged?

[zhelding]

Hi @CloudCally. No further action is required on your end for merging this pull request.

I originally pushed commits to this pull request as a proof of concept for our general process of aligning code with our recent service packages refactor.

This pull request will now be addressed via our standard prioritization process. Unfortunately, given the large quantity of issues and pull requests we receive, we are not always able to review every pull request in a timely manner.

We prioritize contributions that provide the greatest value to the largest number of users -- which we primarily infer based on the number of 👍 reactions. Additionally, an explanation of the particular use case for a contribution can provide information on how the changes might be useful in a broader context.

You can get a view of the wider development plans for the provider via our road map, published quarterly.

Thank you again for your contribution and your patience.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccFMS_serial/Policy/basic PKG=fms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fms/... -v -count 1 -parallel 20 -run='TestAccFMS_serial/Policy/basic'  -timeout 180m
=== RUN   TestAccFMS_serial
=== RUN   TestAccFMS_serial/Policy
=== RUN   TestAccFMS_serial/Policy/basic
--- PASS: TestAccFMS_serial (2082.58s)
    --- PASS: TestAccFMS_serial/Policy (2082.58s)
        --- PASS: TestAccFMS_serial/Policy/basic (2082.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	2086.071s
% make testacc TESTS=TestAccFMS_serial/Policy/tags PKG=fms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fms/... -v -count 1 -parallel 20 -run='TestAccFMS_serial/Policy/tags'  -timeout 180m
=== RUN   TestAccFMS_serial
=== RUN   TestAccFMS_serial/Policy
=== RUN   TestAccFMS_serial/Policy/tags
--- PASS: TestAccFMS_serial (1191.19s)
    --- PASS: TestAccFMS_serial/Policy (1191.19s)
        --- PASS: TestAccFMS_serial/Policy/tags (1191.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	1194.907s

[ewbankkit]

@CloudCally @Victorp99 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.