Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_fms_policy resource policy tagging functionality #19961

Closed
amckruit opened this issue Jun 25, 2021 · 2 comments · Fixed by #21295
Closed

Add aws_fms_policy resource policy tagging functionality #19961

amckruit opened this issue Jun 25, 2021 · 2 comments · Fixed by #21295
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service.
Milestone

Comments

@amckruit
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Link to AWS API Doc https://docs.aws.amazon.com/fms/2018-01-01/APIReference/API_TagResource.html#API_TagResource_RequestSyntax
AWS Firewall Manager supports policy tags (separate from resource_tags) directly in the GUI but they aren't represented in the tf resource documentation, and aren't present when the resource is imported after tags are manually assigned. I'd like to request the addition of tagging functionality for the aws_fms_policy resource

New or Affected Resource(s)

  • aws_fms_policy resource
@amckruit amckruit added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 25, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/fms Issues and PRs that pertain to the fms service. labels Jun 25, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 28, 2021
@github-actions github-actions bot added this to the v4.2.0 milestone Feb 17, 2022
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service.
Projects
None yet
2 participants