Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused FMS resources support for aws_fms_policy #21294

Closed
CloudCally opened this issue Oct 13, 2021 · 2 comments · Fixed by #21295
Closed

Delete unused FMS resources support for aws_fms_policy #21294

CloudCally opened this issue Oct 13, 2021 · 2 comments · Fixed by #21295
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service. service/waf Issues and PRs that pertain to the waf service.
Milestone

Comments

@CloudCally
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support for the aws_fms_policy resource to be able to use the DeleteUnusedFMManagedResources FMS policy property. Currently it is not available and results in the resource always having DeleteUnusedFMManagedResources property set to false if created by Terraform.

New or Affected Resource(s)

  • aws_fms_policy

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
resource "aws_fms_policy" "example" {
  name                        = "FMS-Policy-Example"
  delete_unused_fms_resources = true
  exclude_resource_tags       = false
  remediation_enabled         = false
  resource_type_list          = ["AWS::ElasticLoadBalancingV2::LoadBalancer"]

  security_service_policy_data {
    type = "WAFV2"

    managed_service_data = jsonencode({
      type = "WAFV2",
      ruleGroups = [{
        id = aws_wafregional_rule_group.example.id
        overrideAction = {
          type = "COUNT"
        }
      }]
      defaultAction = {
        type = "BLOCK"
      }
      overrideCustomerWebACLAssociation = false
    })
  }
}

resource "aws_wafregional_rule_group" "example" {
  metric_name = "WAFRuleGroupExample"
  name        = "WAF-Rule-Group-Example"
}

References

@CloudCally CloudCally added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 13, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/fms Issues and PRs that pertain to the fms service. service/waf Issues and PRs that pertain to the waf service. labels Oct 13, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 13, 2021
@github-actions github-actions bot added this to the v4.2.0 milestone Feb 17, 2022
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service. service/waf Issues and PRs that pertain to the waf service.
Projects
None yet
2 participants