tools/importer-rest-api-specs: refactoring the Parser package
#4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
changed the title
tools/importer-rest-api-specs: refactoring the Parser package
manicminer
added
tool/importer-rest-api-specs
stephybun
previously approved these changes
Jul 31, 2024
|
|
||
| Where possible we use the terminology `API Definition` since these are implementation details - but this more specific terminology will be used where necessary. | ||
|
|
||
| TODO also mention Supplemental Data |
There was a problem hiding this comment.
@manicminer do you have context on this?
manicminer
force-pushed
the
refactor/importer-rest-api-specs-iv
branch
2 times, most recently
from
5585fc2
to
273f87f
Compare
stephybun
reviewed
Oct 1, 2024
tools/importer-rest-api-specs/internal/components/apidefinitions/parser/parsingcontext/build.go
Outdated
Show resolved
Hide resolved
tools/importer-rest-api-specs/internal/components/apidefinitions/parser/parsingcontext/build.go
Outdated
Show resolved
Hide resolved
tools/importer-rest-api-specs/internal/components/apidefinitions/parser/parsingcontext/build.go
Outdated
Show resolved
Hide resolved
| // if this is a parent model, look for implementations. this will currently only work for children defined in | ||
| // the same swagger file. |
There was a problem hiding this comment.
Do we handle the case where the children are defined in a different swagger file somewhere else in build.go?
Context: #3727
There was a problem hiding this comment.
Yes, this should get picked up by https://github.com/hashicorp/pandora/pull/4307/files#diff-d2cb55dda7e9facde77a39139c64afb00da29f5f92150f1e9eec14766b11c4b1 (which I think is your original implementation)
manicminer
force-pushed
the
refactor/importer-rest-api-specs-iv
branch
from
f57a3a2
to
23eccdf
Compare
manicminer
added a commit
that referenced
this pull request
Oct 1, 2024
…ers out into the new structure
…a Data Workaround
…e over to using the SDK types/new path This is a copy and patch up, since I want to leave the existing code path as-is for the moment, to break it apart more effectively
… Service/APIVersion
…rkarounds` package
…age into the new structure
…to the new package This wants refactoring, but moving it over allows cleaning the rest up
…kage There's a bunch of these, and whilst these'll get replaced in time with #4017 but for now this cleans this up
…since it doesn't seem to be required for DataFactory models as they use external Swagger Refs.
…licates (avoid parsing the same tag twice)
This reverts commit 31b45ca.
… more explicit" This reverts commit 71a166f.
… `go-openapi/jsonreference`, and `go-openapi/spec`
…resolve all remote references
…L-decoded when parsing from the Ref URL fragment
…pect full ancestry
…ame set of resources
…der when parsing operations, as this was never utilised and leads to skipping resources/operations
stephybun
force-pushed
the
refactor/importer-rest-api-specs-iv
branch
from
d9f992a
to
1da6920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Parser package into
apidefinitions- and removes the old logic/pipelineRight now this mostly works and requires a few fixes around Discriminators/Supplementary Data that @manicminer is going to pick up
Mostly fixes/rounds out #3754