Skip to content

Conversation

@hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #25783 to be assessed for backporting due to the inclusion of the label backport/website.

The below text is copied from the body of the original PR.


Description

This updates the existing iframe for youtube to a VideoEmbed component. This is so we can standardize how we are serving and tracking video plays across DevDot.

Related PR: hashicorp/dev-portal#2699

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/iframe-to-videoembed/hideously-enabled-crayfish branch from a128088 to 4094511 Compare April 29, 2025 17:39
@hc-github-team-nomad-core hc-github-team-nomad-core requested a review from a team as a code owner April 29, 2025 17:39
@aimeeu aimeeu merged commit 8152ab4 into stable-website Apr 29, 2025
6 of 8 checks passed
@aimeeu aimeeu deleted the backport/iframe-to-videoembed/hideously-enabled-crayfish branch April 29, 2025 17:40
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants