Posthog tracking for video embeds starts #2699
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Forty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
…corp/dev-portal into video-embed-posthog-tracking
im2nguyen
requested review from
a team,
heatlikeheatwave and
prestonbourne
and removed request for
a team
im2nguyen
changed the title
src/hooks/use-posthog-analytics.ts
Outdated
| /** | ||
| * Enables PostHog video start tracking | ||
| */ | ||
| export function trackVideoStart(video_id: string) { | ||
| if (!window?.posthog) return | ||
| window.posthog.capture('video_start', { video_id }) | ||
| } | ||
|
|
There was a problem hiding this comment.
nit picky but since this is defined in hooks/use-posthog-analytics
i'd only expect hooks and specifically the usePosthogAnalytics hook to be here
imo putting this in the lib directory lib/posthog-events or something similar sets dev-portal up quite nicely to begin scaling with posthog custom events 😄
There was a problem hiding this comment.
just updated, thanks for the feedback 😄
|
Is there an asana task for this? |
prestonbourne
left a comment
prestonbourne
left a comment
There was a problem hiding this comment.
looks good from my pov but deferring final approval to a dev portal engineer 👍🏽
|
@heatlikeheatwave this is the Asana ticket for it: https://app.asana.com/0/1202801212949828/1209530615984378/f |
|
@heatlikeheatwave @im2nguyen what's needed for us to approve and merge this PR? |
|
@kaitlynnefuery I think this is a standalone PR! once this is reviewed, we'll just add the VideoEmbeds in the downstream product repos 😄 |
|
@im2nguyen, where can I find the |
Co-authored-by: Heat Hamilton <[email protected]>
This reverts commit 9eac670.
4 participants
🔗 Relevant links
This PR updates the VideoEmbed to send a custom PostHog event
video_startwhenever someone starts a video play. This works on both wistia and youtube videos.In addition, it adds
VideoEmbedas an available MDX component for docs. This lets us useVideoEmbedinstead of iframe for videos in documentation, so the behavior is consistent throughout the platform.🗒️ What
🤷 Why
🛠️ How
📸 Design Screenshots
🧪 Testing
Related PR: hashicorp/terraform-docs-common#866
dev-portaland check out thevideo-embed-posthog-trackingbranchdocker build . -t dev-portal-video-tracking)DOCKER_IMAGE_LOCAL="dev-portal-local"in this repo'swebsite/Makefilefile todev-portal-video-tracking.make website/local). You may need to add.env.localtowebsite./terraform/cloud-docs/recommended-practicesvideo_playevent is triggered💭 Anything else?