E2E: refactor Connect tests to use stdlib testing

[tgross]

Migrate our E2E tests for Connect off the old framework in preparation for writing E2E tests for transparent proxy and the updated workload identity workflow. Mark the tests that cover the legacy Consul token submitted workflow.

Ref: #20175

---

Run against our E2E cluster setup on AWS:

$ go test -v -count=1 ./connect
=== RUN   TestConnect_LegacyACLs
=== RUN   TestConnect_LegacyACLs/ConnectDemo
=== RUN   TestConnect_LegacyACLs/ConnectDemoNamespaced
=== RUN   TestConnect_LegacyACLs/ConnectNativeDemo
=== RUN   TestConnect_LegacyACLs/ConnectIngressGatewayDemo
=== RUN   TestConnect_LegacyACLs/ConnectTerminatingGateway
--- PASS: TestConnect_LegacyACLs (97.62s)
    --- PASS: TestConnect_LegacyACLs/ConnectDemo (29.60s)
    --- PASS: TestConnect_LegacyACLs/ConnectDemoNamespaced (24.57s)
    --- PASS: TestConnect_LegacyACLs/ConnectNativeDemo (14.37s)
    --- PASS: TestConnect_LegacyACLs/ConnectIngressGatewayDemo (14.38s)
    --- PASS: TestConnect_LegacyACLs/ConnectTerminatingGateway (14.44s)
=== RUN   Test_serviceOfSIToken
--- PASS: Test_serviceOfSIToken (0.00s)
=== RUN   TestConnect_ClientRestart
    client_test.go:17: skipping test that does nomad agent restart
--- SKIP: TestConnect_ClientRestart (0.00s)
=== RUN   TestConnect
=== RUN   TestConnect/ConnectDemo
=== RUN   TestConnect/ConnectCustomSidecarExposed
=== RUN   TestConnect/ConnectNativeDemo
=== RUN   TestConnect/ConnectIngressGatewayDemo
=== RUN   TestConnect/ConnectMultiIngress
=== RUN   TestConnect/ConnectTerminatingGateway
=== RUN   TestConnect/ConnectMultiService
--- PASS: TestConnect (109.72s)
    --- PASS: TestConnect/ConnectDemo (22.49s)
    --- PASS: TestConnect/ConnectCustomSidecarExposed (17.32s)
    --- PASS: TestConnect/ConnectNativeDemo (14.31s)
    --- PASS: TestConnect/ConnectIngressGatewayDemo (13.26s)
    --- PASS: TestConnect/ConnectMultiIngress (13.31s)
    --- PASS: TestConnect/ConnectTerminatingGateway (13.40s)
    --- PASS: TestConnect/ConnectMultiService (15.38s)
PASS
ok      github.com/hashicorp/nomad/e2e/connect  207.353s

[shoenig]

I think this takes care of most of #19250 no?

[shoenig]

LGTM!

[tgross]

I think this takes care of most of #19250 no?

Halfway... part of the e2e/consul package still hasn't been migrated over. This PR was blocking finishing up tproxy E2E tests. So I wanted to land this first. Once I've got those done, I'll come back and finish the e2e/consul package to close out #19250. (Assigning myself #19250 so I don't forget 😀 )

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.