Finish reference origin collection for all constraints #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-origin-collection-finish
branch
from
30b2b95
to
d86de41
Compare
radeksimko
force-pushed
the
f-origin-collection-finish
branch
2 times, most recently
from
7c88045
to
f6222e1
Compare
jpogran
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #228
Legacy tests were updated in 7c88045
UX
Unfortunately most of the code is pretty much no-op on the UX side of things without #239 - i.e. there isn't much to demo here. The updated legacy tests + new tests hopefully prove that it's working well though!