Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish reference target collection for all constraints #239

Merged
merged 26 commits into from
Mar 30, 2023
Merged

Finish reference target collection for all constraints #239

merged 26 commits into from
Mar 30, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Mar 20, 2023 •
edited
Loading

@radeksimko radeksimko added the enhancement New feature or request label Mar 20, 2023
@radeksimko radeksimko self-assigned this Mar 20, 2023
@radeksimko radeksimko mentioned this pull request Mar 20, 2023
Closed
@radeksimko radeksimko mentioned this pull request Mar 23, 2023
Merged
@radeksimko radeksimko changed the title Finish reference target collection implementation Finish reference collection implementation Mar 24, 2023
@radeksimko radeksimko force-pushed the f-target-collection-finish branch 9 times, most recently from 52560ed to 75e4d0c Compare March 27, 2023 17:24
@radeksimko radeksimko mentioned this pull request Mar 27, 2023
Merged
@radeksimko radeksimko changed the title Finish reference collection implementation Finish reference target collection implementation Mar 27, 2023
@radeksimko radeksimko changed the title Finish reference target collection implementation Finish reference target collection for all constraints Mar 27, 2023
@radeksimko radeksimko force-pushed the f-target-collection-finish branch 3 times, most recently from 4ecb4c4 to e661bc9 Compare March 28, 2023 19:46
@radeksimko radeksimko force-pushed the f-target-collection-finish branch 3 times, most recently from 5c324fa to e194ebf Compare March 29, 2023 11:55
@radeksimko
decoder: Collect 'any' type by inferring it from value (LiteralType/O…
3ebb7ee 
…neOf)
@radeksimko
decoder: fix block body inferred target collection
e26004e
@radeksimko
decoder: Account for JSON in ref. targets for LiteralType
3a6053f
@radeksimko
decoder: Account for JSON keys in rawObjectKey
7ea314c
@radeksimko
decoder: Account for JSON when collecting targets for Map/Object
bd005c7
@radeksimko
decoder: Add tests for reference targets (OneOf)
e7f8aa9
@radeksimko
decoder: Account for legacy JSON syntax in Reference
25b482b
@radeksimko
schema: Fix typo in validation error
70449de
@radeksimko
decoder: Only pass TargetContext when there are targets to collect
7b5359e
@radeksimko
decoder: Add tests for reference targets (List)
baea9c1
@radeksimko
decoder: Add tests for reference targets (Set)
0c30af2
@radeksimko
decoder: Add tests for reference targets (Tuple)
d687428
@radeksimko
decoder: Add tests for reference targets (Object)
3831dd7
@radeksimko
decoder: Add tests for reference targets (Map)
387fb09
@radeksimko
decoder: Add tests for reference targets (LiteralType)
261c5e6
@radeksimko radeksimko marked this pull request as ready for review March 29, 2023 19:25
@radeksimko radeksimko requested a review from a team as a code owner March 29, 2023 19:25
jpogran
jpogran approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@radeksimko radeksimko merged commit 4644fb0 into main Mar 30, 2023
@radeksimko radeksimko deleted the f-target-collection-finish branch March 30, 2023 17:17
@radeksimko radeksimko mentioned this pull request Apr 5, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees

@radeksimko radeksimko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

decoder: Finish reference collection implementation for Constraint
2 participants
@radeksimko @jpogran