Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder: Add support for List as Constraint #195

Merged
merged 10 commits into from
Mar 13, 2023
Merged

decoder: Add support for List as Constraint #195

merged 10 commits into from
Mar 13, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jan 25, 2023 •
edited by dbanck
Loading

Part of hashicorp/terraform-ls#496

Depends on #196

TODO

  • completion: schema empty completion data
  • completion: handling of multiline elements (+tests)
  • completion: tests
  • hover: tests
  • semantic tokens: tests
  • completion: review existing tests
  • hover: review existing tests
  • semantic tokens: review existing tests

Later

  • reference targets: Decide how to collect parent target for the whole list
  • reference origins: tests
  • reference targets: tests

@radeksimko radeksimko added the enhancement New feature or request label Jan 25, 2023
@radeksimko radeksimko self-assigned this Jan 25, 2023
@radeksimko radeksimko changed the title decoder/schema: Add support for List decoder/schema: Add support for List as Constraint Jan 25, 2023
@radeksimko radeksimko mentioned this pull request Jan 25, 2023
Merged
@radeksimko radeksimko force-pushed the f-expr-cons-list branch 6 times, most recently from df63f91 to 3fe7b86 Compare January 30, 2023 13:01
@radeksimko radeksimko mentioned this pull request Feb 16, 2023
Merged
@radeksimko radeksimko assigned dbanck and unassigned radeksimko Feb 20, 2023
@dbanck dbanck force-pushed the f-expr-cons-list branch 3 times, most recently from 1f255d5 to a5df433 Compare February 24, 2023 13:58
@radeksimko radeksimko changed the title decoder/schema: Add support for List as Constraint decoder: Add support for List as Constraint Mar 7, 2023
@dbanck dbanck force-pushed the f-expr-cons-list branch 2 times, most recently from 8495c38 to dd97e6a Compare March 9, 2023 09:51
@radeksimko radeksimko mentioned this pull request Mar 9, 2023
Merged
5 tasks
@dbanck dbanck force-pushed the f-expr-cons-list branch 2 times, most recently from a6d0f21 to 43722f1 Compare March 10, 2023 10:59
@dbanck dbanck marked this pull request as ready for review March 10, 2023 14:07
@dbanck dbanck requested a review from a team as a code owner March 10, 2023 14:07
@radeksimko radeksimko mentioned this pull request Mar 13, 2023
Closed
15 tasks
radeksimko
radeksimko commented Mar 13, 2023
View reviewed changes
Copy link
Member Author

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screenshot 2023-03-13 at 08 28 46

decoder/expr_list_ref_targets.go Show resolved Hide resolved
@dbanck dbanck merged commit 9734d18 into main Mar 13, 2023
@dbanck dbanck deleted the f-expr-cons-list branch March 13, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@dbanck dbanck

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @dbanck