Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Add support for TypeDeclaration as Constraint #183

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jan 16, 2023

Part of hashicorp/terraform-ls#496

TODO

  • completion: review new tests added to decoder: Add support for Object as Constraint #203 and bring them over, if they're relevant for TypeDeclaration too (esp. negative tests for "dead space" before and after object items)
  • completion: review new tests added to decoder: Add support for List as Constraint #195 and bring them over, if they're relevant for TypeDeclaration too (inside tuple([ ])))
  • completion: review existing tests
  • hover: review existing tests
  • semantic tokens: review existing tests

UX

2023-04-27 14 39 17

@radeksimko radeksimko added the enhancement New feature or request label Jan 16, 2023
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch 3 times, most recently from f39fc26 to a8a4809 Compare January 17, 2023 13:29
@radeksimko radeksimko self-assigned this Jan 23, 2023
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch 4 times, most recently from a27ed6c to 041c5d0 Compare January 27, 2023 14:05
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch 7 times, most recently from c1f53ff to 4716234 Compare February 17, 2023 10:54
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch 2 times, most recently from 9473399 to c1073ed Compare February 17, 2023 17:22
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch 4 times, most recently from bf84efa to 8a00f43 Compare February 21, 2023 20:51
@radeksimko radeksimko changed the title decoder/schema: Add support for TypeDeclaration as Constraint decoder: Add support for TypeDeclaration as Constraint Mar 7, 2023
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch from 8a00f43 to b193dda Compare March 7, 2023 14:20
@radeksimko radeksimko mentioned this pull request Mar 7, 2023
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch from b193dda to 1a448c4 Compare March 9, 2023 13:15
@radeksimko radeksimko force-pushed the f-expr-cons-type-declaration branch from 1a448c4 to 0436bc8 Compare March 9, 2023 14:49
@radeksimko radeksimko assigned jpogran and unassigned radeksimko Mar 9, 2023
@jpogran jpogran force-pushed the f-expr-cons-type-declaration branch from 0436bc8 to f38d132 Compare March 16, 2023 16:42
@jpogran jpogran force-pushed the f-expr-cons-type-declaration branch 2 times, most recently from 2d69894 to 66100c4 Compare March 20, 2023 16:38
@radeksimko radeksimko marked this pull request as ready for review March 20, 2023 18:49
@radeksimko radeksimko requested a review from a team as a code owner March 20, 2023 18:49
decoder/hover_test.go Outdated Show resolved Hide resolved
@jpogran jpogran force-pushed the f-expr-cons-type-declaration branch from 8d91a5b to 1f0b924 Compare March 22, 2023 15:30
@radeksimko radeksimko merged commit 7d15ebe into main Mar 22, 2023
@radeksimko radeksimko deleted the f-expr-cons-type-declaration branch March 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants