Merged
Conversation
louisruch
requested review from
ddebko and
jefferai
and removed request for
jefferai
ddebko
approved these changes
Nov 26, 2024
jefferai
approved these changes
Nov 26, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates awsulti deps
The AWS SDK use to attempt load the default profile and ignore a not exist error, regardless of the
SharedConfigProfileoption being provided.However between
v1.18.33and now the SDK no longer does this, if a profile is explicitly set via theSharedConfigProfileoption or an env var, it will fail if the profile does not exist, even if this profile isdefault. See https://github.com/aws/aws-sdk-go-v2/blob/main/config/config.go#L216. It will however still attempt to load thedefaultprofile without being prompted to do so.The change to
go-secure-stdlibhere means that when callingGenerateCredentialChainif the caller does not provide a profile, and they are loading the 'default' profile we will no longer populate Profile field in the go-secure-stdlib CredentialConfig. However it should be said the previously we would set theProfilefiled todefaulteven if thedefaultprofile was not used and does not exist.