Skip to content

chore(deps): Update aws-sdk-go-v2#128

Closed
hugoghx wants to merge 2 commits intomainfrom
hugo-awsutilv2-upd-deps
Closed

chore(deps): Update aws-sdk-go-v2#128
hugoghx wants to merge 2 commits intomainfrom
hugo-awsutilv2-upd-deps

Conversation

@hugoghx
Copy link
Copy Markdown

@hugoghx hugoghx commented Jul 12, 2024

Important: Due to underlying changes in the SDK, awsutil/v2 will no
longer automatically load the "default" AWS shared profile if none is
provided. To load a shared profile, you'll need to set the AWS_PROFILE
env var.


After merging this PR, a new awsutil/v2.1.0 tag and GitHub release will be created.

hugoghx added 2 commits July 12, 2024 14:58
Important: Due to underlying changes in the SDK, awsutil/v2 will no
longer automatically load the "default" AWS shared profile if none is
provided. To load a shared profile, you'll need to set the AWS_PROFILE
env var.
@hugoghx hugoghx requested a review from ddebko July 12, 2024 15:34
@hugoghx hugoghx self-assigned this Jul 12, 2024
Copy link
Copy Markdown
Contributor

@ddebko ddebko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin container job is failing, you might just need to rerun it?
The error looks strange:

TestExamplePlugin/runsc/simulated_plugin_error: plugin shut down with non-0 exit code

@hugoghx
Copy link
Copy Markdown
Author

hugoghx commented Jul 12, 2024

The plugin container job is failing, you might just need to rerun it? The error looks strange:

TestExamplePlugin/runsc/simulated_plugin_error: plugin shut down with non-0 exit code

Yeah, I re-ran it once and it just failed again. Currently looking into this - I think it's unlikely that these changes are making it fail though

@hugoghx hugoghx requested a review from jefferai July 12, 2024 15:48
@hugoghx
Copy link
Copy Markdown
Author

hugoghx commented Jul 12, 2024

Adding @jefferai as we need an authorised user to approve these changes

@hugoghx
Copy link
Copy Markdown
Author

hugoghx commented Jul 12, 2024

I wasn't able to find much on why plugincontainer is failing. I re-ran it once more and it failed again - My only guess here is that something changed in the dependencies we use to run that test, given that we always pull latest for some of them.

I've also noticed, looking at all the actions, that this is the case for other PRs, and the only plugincontainer test that has passed was 4 months ago with the last merge to main.

There's also some PRs targeting plugincontainer #126 #125 #123

@louisruch
Copy link
Copy Markdown
Contributor

Oh I see @hugoghx tried to do this a while ago, I am closing this in favor of #143

@louisruch louisruch closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants