Add IBM Key Protect (IBM Cloud KMS) wrapper (#23)#292
Merged
Conversation
--------- Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds IBM Key Protect (IBM Cloud KMS) wrapper support to the go-kms-wrapping library. This enables encryption and decryption operations using IBM Cloud's Key Protect service.
Key changes:
- Adds a complete IBM Key Protect wrapper implementation with configuration options and KMS client integration
- Includes comprehensive acceptance tests for the wrapper functionality
- Updates project documentation and constants to include the new wrapper type
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| wrappers/ibmkp/options.go | Implements configuration option parsing and wrapper setup functions |
| wrappers/ibmkp/ibmkp_acc_test.go | Provides acceptance tests for IBM Key Protect wrapper functionality |
| wrappers/ibmkp/ibmkp.go | Core wrapper implementation with encrypt/decrypt operations |
| wrappers/ibmkp/go.mod | Go module definition with IBM Key Protect client dependency |
| const.go | Adds wrapper type constant for IBM Key Protect |
| README.md | Updates documentation to include IBM Key Protect in supported wrappers list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mgaffney
previously approved these changes
Oct 2, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mikemountain
previously approved these changes
Oct 2, 2025
mikemountain
previously approved these changes
Oct 2, 2025
mgaffney
previously approved these changes
Oct 2, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mgaffney
approved these changes
Oct 2, 2025
mikemountain
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls over the PR inadvertently committed to the
dev-v2branch.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.