Add IBM Key Protect (IBM Cloud KMS) wrapper#23
Conversation
|
Hi there! Please see PRs #55 and up to see how the package is changing. If you can update it to how the lib is changing and PR against the |
|
Hi @jefferai, sorry delay, busy week, could you review and merge please? It will help us a lot. Regards, |
|
Hi there, this feature would be welcome for some projects I'm working on. Is there anything I could do to help? |
|
This would be very helpful for me too. Now that IBM has acquired HashiCorp, can this get prioritized? |
|
hi @jefferai can you please help to check this pr again? |
Closes hashicorp#23 Signed-off-by: Pierre-Henri Symoneaux <pierre-henri.symoneaux@ovhcloud.com>
|
Given HashiCorp's acquisition by IBM we'll be looking for some IBM maintainers for this and to officially support it. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for IBM Key Protect (IBM Cloud KMS) as a new key wrapping implementation. This allows IBM Key Protect to be used as an external key management system for envelope encryption, following the same pattern as other cloud KMS providers.
- Implements the IBM Key Protect wrapper with envelope encryption support
- Adds configuration options for API key, endpoint, instance ID, and key ID
- Includes comprehensive acceptance tests for the new IBM Key Protect integration
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wrappers/ibmkp/ibmkp.go | Core IBM Key Protect wrapper implementation with encrypt/decrypt methods |
| wrappers/ibmkp/options.go | Configuration options and parsing logic for the IBM Key Protect wrapper |
| wrappers/ibmkp/ibmkp_acc_test.go | Acceptance tests for IBM Key Protect wrapper functionality |
| wrappers/ibmkp/go.mod | Go module definition with dependencies for IBM Key Protect wrapper |
| const.go | Adds new wrapper type constant for IBM Key Protect |
| README.md | Updates documentation to list IBM Key Protect as supported wrapper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
--------- Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>
* Add IBM Key Protect (IBM Cloud KMS) wrapper (#23) --------- Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com> Co-authored-by: Luiz <luizgn@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Hi, these changes add support to IBM Key Protect.
Could you review code please?
Regards,
Luiz