Skip to content

Add IBM Key Protect (IBM Cloud KMS) wrapper#23

Merged
jefferai merged 8 commits intohashicorp:dev-v2from
luizgn:master
Oct 2, 2025
Merged

Add IBM Key Protect (IBM Cloud KMS) wrapper#23
jefferai merged 8 commits intohashicorp:dev-v2from
luizgn:master

Conversation

@luizgn
Copy link
Copy Markdown
Contributor

@luizgn luizgn commented Aug 25, 2020

Hi, these changes add support to IBM Key Protect.

Could you review code please?

Regards,
Luiz

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Aug 25, 2020

CLA assistant check
All committers have signed the CLA.

@jefferai
Copy link
Copy Markdown
Member

jefferai commented Mar 1, 2022

Hi there!

Please see PRs #55 and up to see how the package is changing. If you can update it to how the lib is changing and PR against the dev-v2 branch that would be great! We're nearing the end of the v2 dev cycle and will move it to the default branch soon.

@luizgn luizgn changed the base branch from main to dev-v2 March 5, 2022 10:15
@luizgn
Copy link
Copy Markdown
Contributor Author

luizgn commented Mar 7, 2022

Hi @jefferai, sorry delay, busy week, could you review and merge please? It will help us a lot.

Regards,
Luiz

@maxdebayser
Copy link
Copy Markdown

Hi there, this feature would be welcome for some projects I'm working on. Is there anything I could do to help?

@merickso
Copy link
Copy Markdown

merickso commented Mar 6, 2025

This would be very helpful for me too. Now that IBM has acquired HashiCorp, can this get prioritized?

@claytonsilva
Copy link
Copy Markdown

hi @jefferai can you please help to check this pr again?

plisss

cipherboy pushed a commit to cipherboy/hashicorp-go-kms-wrapping that referenced this pull request Mar 22, 2025
Closes hashicorp#23

Signed-off-by: Pierre-Henri Symoneaux <pierre-henri.symoneaux@ovhcloud.com>
@jefferai
Copy link
Copy Markdown
Member

Given HashiCorp's acquisition by IBM we'll be looking for some IBM maintainers for this and to officially support it.

@jefferai jefferai requested a review from Copilot September 29, 2025 16:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for IBM Key Protect (IBM Cloud KMS) as a new key wrapping implementation. This allows IBM Key Protect to be used as an external key management system for envelope encryption, following the same pattern as other cloud KMS providers.

  • Implements the IBM Key Protect wrapper with envelope encryption support
  • Adds configuration options for API key, endpoint, instance ID, and key ID
  • Includes comprehensive acceptance tests for the new IBM Key Protect integration

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
wrappers/ibmkp/ibmkp.go Core IBM Key Protect wrapper implementation with encrypt/decrypt methods
wrappers/ibmkp/options.go Configuration options and parsing logic for the IBM Key Protect wrapper
wrappers/ibmkp/ibmkp_acc_test.go Acceptance tests for IBM Key Protect wrapper functionality
wrappers/ibmkp/go.mod Go module definition with dependencies for IBM Key Protect wrapper
const.go Adds new wrapper type constant for IBM Key Protect
README.md Updates documentation to list IBM Key Protect as supported wrapper

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread wrappers/ibmkp/ibmkp_acc_test.go Outdated
Copy link
Copy Markdown
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With updates, LGTM!

@jefferai jefferai merged commit 3cf3123 into hashicorp:dev-v2 Oct 2, 2025
1 check passed
jefferai added a commit that referenced this pull request Oct 2, 2025
jefferai added a commit that referenced this pull request Oct 2, 2025
---------

Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>
jefferai added a commit that referenced this pull request Oct 2, 2025
* Add IBM Key Protect (IBM Cloud KMS) wrapper (#23)

---------

Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>
Co-authored-by: Luiz <luizgn@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants