-
Notifications
You must be signed in to change notification settings - Fork 16
Added template for new PR creation #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ## Description | ||
|
|
||
| <!-- Provide a summary of what the PR does and why it is being submitted. --> | ||
|
|
||
| ## Related Issue | ||
|
|
||
| <!-- If this PR is linked to any issue, provide the issue number or description here. --> | ||
|
|
||
| ## Type of Change | ||
|
|
||
| - [ ] Bug fix | ||
| - [ ] New feature | ||
| - [ ] Breaking change | ||
| - [ ] Documentation update | ||
| - [ ] Other (Please specify): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I dunno about this section... if "what kind of change is this?" isn't obvious from the Description section, then it's a poorly written description.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 Sometimes bug fixes go along-with a documentation update. Additionally, I'm unsure if this categorization would help the reviewer by huge margin.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. makes sense, removed |
||
|
|
||
| ## How Has This Been Tested? | ||
|
|
||
| <!-- Describe how the changes have been tested. Provide test instructions or details. --> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to suggest adding a link to the internal Jira issue, for PRs from HashiCorp employees (they should know to do this anyways, but...)