Added template for new PR creation#99
Merged
sonamtenzin2 merged 2 commits intomainfrom Apr 14, 2025
Merged
Conversation
tgross
reviewed
Apr 9, 2025
Comment on lines
+9
to
+15
| ## Type of Change | ||
|
|
||
| - [ ] Bug fix | ||
| - [ ] New feature | ||
| - [ ] Breaking change | ||
| - [ ] Documentation update | ||
| - [ ] Other (Please specify): |
Member
There was a problem hiding this comment.
I dunno about this section... if "what kind of change is this?" isn't obvious from the Description section, then it's a poorly written description.
Contributor
There was a problem hiding this comment.
+1
Sometimes bug fixes go along-with a documentation update. Additionally, I'm unsure if this categorization would help the reviewer by huge margin.
Contributor
Author
There was a problem hiding this comment.
makes sense, removed
|
|
||
| ## Related Issue | ||
|
|
||
| <!-- If this PR is linked to any issue, provide the issue number or description here. --> |
Member
There was a problem hiding this comment.
Might be a good idea to suggest adding a link to the internal Jira issue, for PRs from HashiCorp employees (they should know to do this anyways, but...)
mukeshjc
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds description template for new PRs