Fix bugs in Link::Standalone and Link::Inline components
#391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0d8515f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
…butes in link `standalone` and `inline` Co-authored-by: cbfx <[email protected]>
alex-ju
force-pushed
the
extension-of-387
branch
from
c3b7218 to
0d8515f
Compare
Merged
|
@didoo wow, thank you for the extremely quick turnaround on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
While working on https://github.com/hashicorp/cloud-ui/pull/2853/ @cbfx has found a nasty bug in the
Link::StandaloneandLink::Inlinecomponents. Totally my fault, I did a bad job in #227 and #231 and missed this.@cbfx opened a PR to fix this bug in #387, but while adding tests to it I noticed also a
@isHrefExternalprop was missing from theLink::Inlineso I decided the simplest/quickest thing to do was to open a new PR (this one) with all the fixes needed, plus the integration tests added to cover these bugs.🛠️ Detailed description
In this PR I have:
target="_blank"andrel="noopener noreferrer”attributes in linkstandaloneandinline@isHrefExternaldrilling prop from theinlinelinkstandaloneandinlineto cover this bug👀 How to review
👉 Review commit-by-commit or by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.