Fix odd test bug

[Dhaulagiri]

📌 Summary

Fixes #358

Refactors a single test to avoid an odd bug in our test suite

🛠️ Detailed description

After some sleuthing 🕵️ I found out how to reproduce the issue (in CI, never locally 🤷 )

• For unclear reasons our acceptance test creating percy snapshots was running twice
• It started after https://github.com/hashicorp/design-system/pull/217/files was merged
• A lot changed here but nothing stood out to me until some trial and error highlighted the addition of a test using sinon
• If I commented out this test the problem went away
  

  design-system/packages/components/tests/integration/components/hds/interactive/index-test.js

  Lines 133 to 139 in cb38390

  	test('it should dispatch a click event when pressing space key on a link', async function (assert) {
  	await render(hbs`<Hds::Interactive @href="#" id="test-interactive"/>`);
  	var interactiveComponent = document.querySelector('#test-interactive');
  	var keyUpSpy = sinon.spy(interactiveComponent, 'click');
  	await triggerKeyEvent(interactiveComponent, 'keyup', ' ');
  	assert.true(keyUpSpy.calledOnce);
  	});

I'm a bit rusty, but I made a pass at refactoring this test to not use sinon and a) the test "works" and b) the errors are no longer present in our CI runs if you look at one of the tests for components.

Ideally we could understand why this test was causing this in the event we want to add sinon back in the future but I've hit my timebox limit on this for now. My suspicion is that the sinon usage was causing some hidden error that sent things astray.

---

👀 How to review

👉 Review commit-by-commit

Reviewer's checklist:

• +1 Percy if applicable
• Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3f68ce5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
hds-components	✅ Ready (Inspect)	Visit Preview	Jun 16, 2022 at 6:13PM (UTC)
hds-flight-website	✅ Ready (Inspect)	Visit Preview	Jun 16, 2022 at 6:13PM (UTC)

[alex-ju]

Thanks for investigating this! I've also spent some time yesterday trying to replicate the issue locally but no luck.

[alex-ju]

So we rely on the click event bubbling up, then capture it at the parent level using a boolean. Given we only use sinon for this test I'm happy with the change. We may get back to square one if we won't manage to use this pattern for future scenarios, but that's a problem for tomorrow.

[Dhaulagiri]

We may get back to square one if we won't manage to use this pattern for future scenarios

That was my fear with "fixing" it this way as well.

[MelSumner]