Skip to content

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 27, 2022

📌 Summary

In #217 we commented the code for the top banner about Button/Link/CTA in the docs pages, waiting for the designers to update the same banner in Figma. Now that it's updated, we can port the changes in code, and make it visible again.

🛠️ Detailed description

In this PR I have:

  • added back the top banner about “buttons vs links” in the Button doc page

📸 Screenshots

The same banner in Figma:
banner


👀 How to review

👉 Review by files changed

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested review from a team and heatherlarsen May 27, 2022 12:05
@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

⚠️ No Changeset found

Latest commit: 188396a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hds-components ✅ Ready (Inspect) Visit Preview May 30, 2022 at 9:58AM (UTC)
hds-flight-website ✅ Ready (Inspect) Visit Preview May 30, 2022 at 9:58AM (UTC)

Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but should this notice also be available on the Link::Standalone page?

@vercel vercel bot temporarily deployed to Preview – hds-components May 30, 2022 09:58 Inactive
@didoo
Copy link
Contributor Author

didoo commented May 30, 2022

Not blocking, but should this notice also be available on the Link::Standalone page?

I was worried it may be confusing. I've added it back for both links ("standalone" and "inline").

@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 30, 2022 09:58 Inactive
@didoo didoo merged commit 2991afb into main May 30, 2022
@didoo didoo deleted the add-back-banner-on-buttons-vs-links branch May 30, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants