Fix service import deprecation

README.md

@@ -1,3 +1,5 @@
+<!-- TEMPORARY ADDITION SO BRANCH DIVERGES FROM MAIN -->
+
 <picture>
   <source media="(prefers-color-scheme: dark)" srcset="https://github.com/hashicorp/design-system/assets/788096/5d6969b7-f8b4-4ad3-9ece-b16b4527522e" width="300">
   <source media="(prefers-color-scheme: light)" srcset="https://github.com/hashicorp/design-system/assets/788096/8e278094-427f-40cc-912f-9ccd3a0ff879" width="300">

packages/components/src/components/hds/app-side-nav/portal/target.ts

@@ -4,7 +4,7 @@
  */
 
 import Component from '@glimmer/component';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { macroCondition, isTesting } from '@embroider/macros';

packages/components/src/components/hds/side-nav/portal/target.ts

@@ -4,7 +4,7 @@
  */
 
 import Component from '@glimmer/component';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { macroCondition, isTesting } from '@embroider/macros';

packages/components/src/components/hds/time/index.ts

@@ -5,7 +5,7 @@
 
 import Component from '@glimmer/component';
 import { typeOf } from '@ember/utils';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { action } from '@ember/object';
 import type { DisplayType } from '../../../services/hds-time-types.ts';
 

packages/components/src/components/hds/time/range.ts

@@ -4,7 +4,7 @@
  */
 
 import Component from '@glimmer/component';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import type TimeService from '../../../services/hds-time';
 
 export interface HdsTimeRangeSignature {

showcase/app/controllers/application.ts

@@ -4,7 +4,7 @@
  */
 
 import Controller from '@ember/controller';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
 
 import type RouterService from '@ember/routing/router-service';

showcase/app/controllers/page-components.ts

@@ -4,7 +4,7 @@
  */
 
 import Controller from '@ember/controller';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { scheduleOnce } from '@ember/runloop';
 
 import type RouterService from '@ember/routing/router-service';

showcase/app/controllers/page-components/code-block.ts

@@ -6,7 +6,7 @@
 import Controller from '@ember/controller';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { scheduleOnce } from '@ember/runloop';
 import type Owner from '@ember/owner';
 import type RouterService from '@ember/routing/router-service';

showcase/app/controllers/page-components/pagination/index.ts

@@ -6,7 +6,7 @@
 import Controller from '@ember/controller';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 import type RouterService from '@ember/routing/router-service';
 

showcase/app/controllers/page-components/tabs.ts

@@ -6,7 +6,7 @@
 import Controller from '@ember/controller';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 import type RouterService from '@ember/routing/router-service';
 import type { PageComponentsTabsModel } from 'showcase/routes/page-components/tabs';

showcase/app/controllers/page-components/time.ts

@@ -4,7 +4,7 @@
  */
 
 import Controller from '@ember/controller';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 import type TimeService from '@hashicorp/design-system-components/services/hds-time';
 import type { PageComponentsTimeModel } from 'showcase/routes/page-components/time';

showcase/app/controllers/page-utilities.ts

@@ -4,7 +4,7 @@
  */
 
 import Controller from '@ember/controller';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { scheduleOnce } from '@ember/runloop';
 
 import type Owner from '@ember/owner';

website/app/components/doc/page/banner.js

@@ -6,7 +6,7 @@
 import Component from '@glimmer/component';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 const COOKIE_NAME = 'hide-banner';
 

website/app/components/doc/page/header/algolia-search/index.js

@@ -6,7 +6,7 @@
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 import { autocomplete } from '@algolia/autocomplete-js';
 

website/app/components/doc/page/sidebar.js

@@ -7,7 +7,7 @@ import Component from '@glimmer/component';
 import { restartableTask, timeout } from 'ember-concurrency';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 const DEBOUNCE_MS = 250;
 

website/app/components/doc/scroll-to-top/index.js

@@ -5,7 +5,7 @@
 
 import Component from '@glimmer/component';
 import { action } from '@ember/object';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
 
 export default class DocScrollToTopComponent extends Component {

website/app/controllers/application.js

@@ -7,7 +7,7 @@ import Controller from '@ember/controller';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
 import { scheduleOnce } from '@ember/runloop';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { next, later, cancel } from '@ember/runloop';
 import { defaultValidator } from 'ember-a11y-refocus';
 

website/app/controllers/show.js

@@ -4,7 +4,7 @@ import { set, action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
 import { A } from '@ember/array';
 import { schedule } from '@ember/runloop';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 import { showdownConfig } from '../shared/showdown-config';
 

website/app/modifiers/doc-track-event.js

@@ -5,7 +5,7 @@
 
 import Modifier from 'ember-modifier';
 import { registerDestructor } from '@ember/destroyable';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { assert } from '@ember/debug';
 
 export default class DocTrackEvent extends Modifier {

website/app/routes/show.js

@@ -7,7 +7,7 @@ import {
   isNotFoundResponse,
 } from 'ember-fetch/errors';
 import config from 'ember-get-config';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { action } from '@ember/object';
 import { reject } from 'rsvp';
 

website/app/services/event-tracking.js

@@ -4,7 +4,7 @@
  */
 
 import Service from '@ember/service';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { action } from '@ember/object';
 
 export default class EventService extends Service {

website/app/services/head-data.js

@@ -5,7 +5,7 @@
 
 import HeadDataService from 'ember-meta/services/head-data';
 import config from 'ember-get-config';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 export default class CustomHeadDataService extends HeadDataService {
   @service router;

website/docs/components/pagination/index.js

@@ -6,15 +6,15 @@
 import Component from '@glimmer/component';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 const getCursorParts = (cursor, records) => {
   const token = atob(cursor);
   const tokenParts = [...token.split('__')];
   const direction = tokenParts[0];
   const cursorID = parseInt(tokenParts[1]);
   const cursorIndex = records.findIndex(
-    (element) => element.id === parseInt(cursorID)
+    (element) => element.id === parseInt(cursorID),
   );
   return { direction, cursorID, cursorIndex };
 };
@@ -63,13 +63,13 @@ export default class Index extends Component {
 
   get demoCurrentPage() {
     return parseInt(
-      this.router?.currentRoute?.queryParams?.demoCurrentPage ?? 1
+      this.router?.currentRoute?.queryParams?.demoCurrentPage ?? 1,
     );
   }
 
   get demoCurrentPageSize() {
     return parseInt(
-      this.router?.currentRoute?.queryParams?.demoCurrentPageSize ?? 5
+      this.router?.currentRoute?.queryParams?.demoCurrentPageSize ?? 5,
     );
   }
 
@@ -372,7 +372,7 @@ export default class Index extends Component {
     let { newPrevCursor, newNextCursor } = getNewPrevNextCursors(
       this.demoCurrentCursor,
       this.demoCurrentPageSize,
-      this.model.records
+      this.model.records,
     );
     return {
       newPrevCursor,
@@ -413,7 +413,7 @@ export default class Index extends Component {
   get demoPaginatedDataCompact() {
     const { direction, cursorIndex } = getCursorParts(
       this.demoCurrentCursor,
-      this.model.records
+      this.model.records,
     );
 
     let start;
@@ -440,7 +440,7 @@ export default class Index extends Component {
     console.log(
       pageSize !== undefined
         ? `Page changed to "${page}" with page size equal to "${pageSize}"!`
-        : `Page changed to "${page}"!`
+        : `Page changed to "${page}"!`,
     );
   }
 

website/docs/components/tabs/index.js

@@ -5,7 +5,7 @@
 
 import Component from '@glimmer/component';
 import { action } from '@ember/object';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 export default class Index extends Component {
   @service router;
@@ -19,7 +19,7 @@ export default class Index extends Component {
 
   get demoSelectedTab() {
     return parseInt(
-      this.router?.currentRoute?.queryParams?.demoSelectedTab ?? 0
+      this.router?.currentRoute?.queryParams?.demoSelectedTab ?? 0,
     );
   }
 

website/docs/foundations/tokens/index.js

@@ -5,7 +5,7 @@
 
 import Component from '@glimmer/component';
 import { restartableTask, timeout } from 'ember-concurrency';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 import TOKENS_RAW from '@hashicorp/design-system-tokens/dist/docs/products/tokens.json';
 
@@ -16,7 +16,7 @@ const getAliases = (token, TOKENS_RAW) => {
   const path = token.path.join('.');
   return TOKENS_RAW.filter(
     // note: also the original value is prefixed with `$`
-    (item) => item.original.$value === `{${path}.value}`
+    (item) => item.original.$value === `{${path}.value}`,
   ).map((alias) => `{${alias.path.join('.')}}`);
 };
 
@@ -54,7 +54,7 @@ export default class Index extends Component {
             t.name.indexOf(this.searchQuery) !== -1 ||
             // note: we prefix `value` with `$` because we're using the DTCG format
             // we also convert it to string, because in some cases it's a number
-            String(t.$value).indexOf(this.searchQuery) !== -1
+            String(t.$value).indexOf(this.searchQuery) !== -1,
         );
 
         if (filteredTokens.length > 0) {

website/docs/icons/library/index.js

@@ -6,7 +6,7 @@
 import Component from '@glimmer/component';
 import { action } from '@ember/object';
 import { restartableTask, timeout } from 'ember-concurrency';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import { NAMES } from '@hashicorp/design-system-components/components/hds/icon/index';
 
 import catalog from '@hashicorp/flight-icons/catalog.json';
@@ -73,12 +73,12 @@ export default class Index extends Component {
         filteredIcons = this.allIcons.filter(
           (i) =>
             i.size === this.selectedIconSize &&
-            i.searchable.indexOf(this.searchQuery.toLowerCase()) !== -1
+            i.searchable.indexOf(this.searchQuery.toLowerCase()) !== -1,
         );
       }
     } else {
       filteredIcons = this.allIcons.filter(
-        (i) => i.size === this.selectedIconSize
+        (i) => i.size === this.selectedIconSize,
       );
     }
 
@@ -130,7 +130,7 @@ export default class Index extends Component {
     });
 
     this.eventTracking.trackEvent(
-      `Icon Library - Group by Selector - ${selectedGroupType}`
+      `Icon Library - Group by Selector - ${selectedGroupType}`,
     );
   }
 
@@ -147,7 +147,7 @@ export default class Index extends Component {
     });
 
     this.eventTracking.trackEvent(
-      `Icon Library - Size Selector - ${selectedIconSize}`
+      `Icon Library - Size Selector - ${selectedIconSize}`,
     );
   }