-
Notifications
You must be signed in to change notification settings - Fork 51
Fix service import deprecation
#3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
e233399 to
65f6ce2
Compare
658001d to
7b2c87c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need a changelog, bc theres no change for an end user right?
That's my inclination. This feels like it would be useless clutter in a changelog. @alex-ju can you weigh in? |
7c0bc36 to
81a4cea
Compare
📌 Summary
If merged, this PR updates all imports of the
@ember/servicemodule'sservicedecoratorfrom:
import { inject as service } from '@ember/service';to:
import { inject } from '@ember/service';📸 Screenshots
🔗 External links
Jira ticket: HDS-4945
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.