Skip to content

Add missing types to the components barrel file #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

Add missing types to the components barrel file #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6a9d05
Add missing button types to the components barrel file
alex-ju Jun 11, 2025
56b1e9a
Add missing flex/grid types to the components barrel file
alex-ju Jun 11, 2025
227e982
Add changelog entry
alex-ju Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/tasty-teachers-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@hashicorp/design-system-components": patch
---

`Button` - added missing types to the barrel export file

`Layout::Flex` - added missing types to the barrel export file

`Layout::Grid` - added missing types to the barrel export file
9 changes: 9 additions & 0 deletions packages/components/src/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ export { default as HdsBreadcrumbTruncation } from './components/hds/breadcrumb/

// Button
export { default as HdsButton } from './components/hds/button/index.ts';
export * from './components/hds/button/types.ts';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, it was only this one!

Copy link
Member Author

@alex-ju alex-ju Jun 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one of the adopted components missed it. Added exports for Flex and Grid as well for when they get adopted. Other than these they're all in the barrel.


// ButtonSet
export { default as HdsButtonSet } from './components/hds/button-set/index.ts';
Expand Down Expand Up @@ -333,10 +334,18 @@ export { default as HdsAppFrameSidebar } from './components/hds/app-frame/parts/
// Layout > Flex
export { default as HdsLayoutFlex } from './components/hds/layout/flex/index.ts';
export { default as HdsLayoutFlexItem } from './components/hds/layout/flex/item.ts';
export * from './components/hds/layout/flex/types.ts';

// Layout > Grid
export { default as HdsLayoutGrid } from './components/hds/layout/grid/index.ts';
export { default as HdsLayoutGridItem } from './components/hds/layout/grid/item.ts';
// we're being explicit with exports here as AvailableTagNames and AvailableElements are overlapping the Flex exports
export {
HdsLayoutGridAlignValues,
HdsLayoutGridGapValues,
type HdsLayoutGridAligns,
type HdsLayoutGridGaps,
} from './components/hds/layout/grid/types.ts';

// -----------------------------------------------------------
// ### UTILITIES
Expand Down