Add missing types to the components barrel file #2943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
previously approved these changes
Jun 11, 2025
|
|
||
| // Button | ||
| export { default as HdsButton } from './components/hds/button/index.ts'; | ||
| export * from './components/hds/button/types.ts'; |
There was a problem hiding this comment.
Only one of the adopted components missed it. Added exports for Flex and Grid as well for when they get adopted. Other than these they're all in the barrel.
alex-ju
force-pushed
the
alex-ju/add-missing-button-types-to-barrel
branch
from
89f8295 to
227e982
Compare
didoo
approved these changes
Jun 11, 2025
alex-ju
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Reviewed all barrel exports and added a missing entry for the button component.
🔗 External links
Jira ticket: HDS-4937
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.