-
Notifications
You must be signed in to change notification settings - Fork 50
Revive Enterprise Nav components #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
230deee
feat: dont exclude enterprise nav from rollup
2a141e5
feat: deprecate SideNav
bb3c378
chore: add changeset
44469d3
chore: uncomment more stuff
562e87e
chore: lint
eea4e5a
feat: enable enterprise nav integration tests
557898c
feat: app nav in showcase
35905cd
chore: improve changeset
ccf6ca8
fix: include enterprise nav css in exported styles
ffcbde4
feat: add AppSideNav to exported components
dbdc6dd
feat: update AppFrame examples to use AppSideNav
0773339
fix: showcase linting errors
3407aff
fix: remove unneeded app frame example
0f88e44
fix: incorporate feedback
641c8ff
fix: enable percy for AppSideNav
a2bd870
chore: alphabetize
53f7c3d
chore: revert changes to website
6823bcd
revert changes to website again
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": minor | ||
| --- | ||
|
|
||
| `SideNav` - Deprecated the `SideNav` component. Use the `AppSideNav` component in combination with the `AppHeader` component as a replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,93 +3,93 @@ | |
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
|
|
||
| // import Component from '@glimmer/component'; | ||
| import Component from '@glimmer/component'; | ||
|
|
||
| // // HDS components | ||
| // import { | ||
| // HdsAppHeader, | ||
| // HdsAppHeaderHomeLink, | ||
| // HdsDropdown, | ||
| // HdsButton, | ||
| // } from '@hashicorp/design-system-components/components'; | ||
| // HDS components | ||
| import { | ||
| HdsAppHeader, | ||
| HdsAppHeaderHomeLink, | ||
| HdsDropdown, | ||
| HdsButton, | ||
| } from '@hashicorp/design-system-components/components'; | ||
|
|
||
| // // types | ||
| // import type { HdsAppHeaderSignature } from '@hashicorp/design-system-components/components/hds/app-header/index'; | ||
| // import type Owner from '@ember/owner'; | ||
| // types | ||
| import type { HdsAppHeaderSignature } from '@hashicorp/design-system-components/components/hds/app-header/index'; | ||
| import type Owner from '@ember/owner'; | ||
|
|
||
| // export interface MockAppHeaderAppHeaderSignature { | ||
| // Args: { | ||
| // showOrgPicker?: boolean; | ||
| // orgPickerLabel?: string; | ||
| // showRegionPicker?: boolean; | ||
| // showSearch?: boolean; | ||
| // }; | ||
| // Element: HdsAppHeaderSignature['Element']; | ||
| // } | ||
| export interface MockAppHeaderAppHeaderSignature { | ||
| Args: { | ||
| showOrgPicker?: boolean; | ||
| orgPickerLabel?: string; | ||
| showRegionPicker?: boolean; | ||
| showSearch?: boolean; | ||
| }; | ||
| Element: HdsAppHeaderSignature['Element']; | ||
| } | ||
|
|
||
| // export default class MockAppHeaderAppHeader extends Component<MockAppHeaderAppHeaderSignature> { | ||
| // showOrgPicker; | ||
| // orgPickerLabel; | ||
| // showRegionPicker; | ||
| // showSearch; | ||
| export default class MockAppHeaderAppHeader extends Component<MockAppHeaderAppHeaderSignature> { | ||
| showOrgPicker; | ||
| orgPickerLabel; | ||
| showRegionPicker; | ||
| showSearch; | ||
|
|
||
| // constructor(owner: Owner, args: MockAppHeaderAppHeaderSignature['Args']) { | ||
| // super(owner, args); | ||
| // this.showOrgPicker = this.args.showOrgPicker ?? true; | ||
| // this.orgPickerLabel = this.args.orgPickerLabel ?? 'organization-name'; | ||
| // this.showRegionPicker = this.args.showRegionPicker ?? true; | ||
| // this.showSearch = this.args.showSearch ?? true; | ||
| // } | ||
| constructor(owner: Owner, args: MockAppHeaderAppHeaderSignature['Args']) { | ||
| super(owner, args); | ||
| this.showOrgPicker = this.args.showOrgPicker ?? true; | ||
| this.orgPickerLabel = this.args.orgPickerLabel ?? 'organization-name'; | ||
| this.showRegionPicker = this.args.showRegionPicker ?? true; | ||
| this.showSearch = this.args.showSearch ?? true; | ||
| } | ||
|
|
||
| // <template> | ||
| // <HdsAppHeader> | ||
| // <:logo> | ||
| // <HdsAppHeaderHomeLink | ||
| // @icon="hashicorp" | ||
| // @ariaLabel="HashiCorp home menu" | ||
| // @href="#" | ||
| // /> | ||
| // </:logo> | ||
| // <:globalActions> | ||
| // {{#if this.showOrgPicker}} | ||
| // <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| // <dd.ToggleButton @text={{this.orgPickerLabel}} @icon="org" /> | ||
| // <dd.Checkmark> | ||
| // my-organization | ||
| // </dd.Checkmark> | ||
| // </HdsDropdown> | ||
| // {{/if}} | ||
| // </:globalActions> | ||
| // <:utilityActions> | ||
| // {{#if this.showRegionPicker}} | ||
| // <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| // <dd.ToggleButton @text="Europe" @icon="globe" /> | ||
| // <dd.Checkmark @selected={{true}}>Europe</dd.Checkmark> | ||
| // <dd.Checkmark>Americas</dd.Checkmark> | ||
| // </HdsDropdown> | ||
| // {{/if}} | ||
| <template> | ||
| <HdsAppHeader> | ||
| <:logo> | ||
| <HdsAppHeaderHomeLink | ||
| @icon="hashicorp" | ||
| @ariaLabel="HashiCorp home menu" | ||
| @href="#" | ||
| /> | ||
| </:logo> | ||
| <:globalActions> | ||
| {{#if this.showOrgPicker}} | ||
| <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| <dd.ToggleButton @text={{this.orgPickerLabel}} @icon="org" /> | ||
| <dd.Checkmark> | ||
| my-organization | ||
| </dd.Checkmark> | ||
| </HdsDropdown> | ||
| {{/if}} | ||
| </:globalActions> | ||
| <:utilityActions> | ||
| {{#if this.showRegionPicker}} | ||
| <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| <dd.ToggleButton @text="Europe" @icon="globe" /> | ||
| <dd.Checkmark @selected={{true}}>Europe</dd.Checkmark> | ||
| <dd.Checkmark>Americas</dd.Checkmark> | ||
| </HdsDropdown> | ||
| {{/if}} | ||
|
|
||
| // {{#if this.showSearch}} | ||
| // <HdsButton @icon="search" @isIconOnly={{true}} @text="Search" /> | ||
| // {{/if}} | ||
| // <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| // <dd.ToggleIcon @icon="help" @text="help menu" /> | ||
| // <dd.Title @text="Help & Support" /> | ||
| // <dd.Interactive @href="#">Documentation</dd.Interactive> | ||
| // <dd.Interactive @href="#">Tutorials</dd.Interactive> | ||
| // <dd.Interactive @href="#">Terraform Provider</dd.Interactive> | ||
| // <dd.Interactive @href="#">Changelog</dd.Interactive> | ||
| // <dd.Separator /> | ||
| // <dd.Interactive @href="#">Create support ticket</dd.Interactive> | ||
| // <dd.Interactive @href="#">Give feedback</dd.Interactive> | ||
| // </HdsDropdown> | ||
| // <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| // <dd.ToggleIcon @icon="user" @text="user menu" /> | ||
| // <dd.Title @text="Signed In" /> | ||
| // <dd.Description @text="[email protected]" /> | ||
| // <dd.Interactive @href="#" @text="Account Settings" /> | ||
| // </HdsDropdown> | ||
| // </:utilityActions> | ||
| // </HdsAppHeader> | ||
| // </template> | ||
| // } | ||
| {{#if this.showSearch}} | ||
| <HdsButton @icon="search" @isIconOnly={{true}} @text="Search" /> | ||
| {{/if}} | ||
| <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| <dd.ToggleIcon @icon="help" @text="help menu" /> | ||
| <dd.Title @text="Help & Support" /> | ||
| <dd.Interactive @href="#">Documentation</dd.Interactive> | ||
| <dd.Interactive @href="#">Tutorials</dd.Interactive> | ||
| <dd.Interactive @href="#">Terraform Provider</dd.Interactive> | ||
| <dd.Interactive @href="#">Changelog</dd.Interactive> | ||
| <dd.Separator /> | ||
| <dd.Interactive @href="#">Create support ticket</dd.Interactive> | ||
| <dd.Interactive @href="#">Give feedback</dd.Interactive> | ||
| </HdsDropdown> | ||
| <HdsDropdown @enableCollisionDetection={{true}} as |dd|> | ||
| <dd.ToggleIcon @icon="user" @text="user menu" /> | ||
| <dd.Title @text="Signed In" /> | ||
| <dd.Description @text="[email protected]" /> | ||
| <dd.Interactive @href="#" @text="Account Settings" /> | ||
| </HdsDropdown> | ||
| </:utilityActions> | ||
| </HdsAppHeader> | ||
| </template> | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.