Revive Enterprise Nav components #2837

shleewhite · 2025-04-22T16:01:39Z

📌 Summary

If merged, this PR would:

deprecates SideNav component
stop excluding app header and app side nav in the rollup
enable the app header and app side nav tests
bring back AppHeader and AppSideNav to the showcase site

Showcase preview pages

🔗 External links

Jira ticket: HDS-4777

👀 Component checklist

Percy was checked for any visual regression
A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

vercel · 2025-04-22T16:01:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
hds-showcase	✅ Ready (Inspect)	Visit Preview	Apr 25, 2025 9:03pm
hds-website	✅ Ready (Inspect)	Visit Preview	Apr 25, 2025 9:03pm

shleewhite · 2025-04-22T18:45:51Z

@hashicorp/hds-engineering should there be a changelog entry for AppHeader and AppSideNav?

didoo · 2025-04-22T19:54:53Z

@shleewhite a couple of things that jump out to me:

we need to re-add them to the showcase demo pages too
there were some code in the MockApp for the standalone pages in the showcase that was commented/disabled
we need to re-add the percy tests for these pages

maybe you could check the PRs that added (and then removed) all these things, to see what is missing?

shleewhite · 2025-04-22T20:40:54Z

@shleewhite a couple of things that jump out to me:

we need to re-add them to the showcase demo pages too

there were some code in the MockApp for the standalone pages in the showcase that was commented/disabled

we need to re-add the percy tests for these pages

maybe you could check the PRs that added (and then removed) all these things, to see what is missing?

For sure, I can re-add those. The tickets to bring back enterprise nav were broken up into 2 parts (1 to revive the components and 1 to bring back the artifacts) so I wasn't sure how to break up the work.

didoo · 2025-04-22T20:48:36Z

For sure, I can re-add those. The tickets to bring back enterprise nav were broken up into 2 parts (1 to revive the components and 1 to bring back the artifacts) so I wasn't sure how to break up the work.

@shleewhite I see. Maybe it's easier to review if it's done in a single PR so we can make sure all the tests are passing, the showcase pages are working, etc? (like if it was the PR of new components).

packages/components/src/components/hds/side-nav/index.ts

.changeset/real-yaks-press.md

didoo · 2025-04-24T09:08:42Z

@shleewhite let me know when this is ready for review, I can do it

didoo · 2025-04-24T20:10:56Z

@shleewhite I am about to review the PR.

In the meantime, quick question: do you think there is a way for us to test the changes in a consumer application, let's say Cloud UI and/or Terraform? Just to make sure everything works as expected.

didoo

Left a few minor comments. Overall is ready to go, up to you if you want to make changes (happy to re-approve)

.changeset/real-yaks-press.md

didoo · 2025-04-24T20:41:29Z

showcase/tests/integration/components/hds/app-header/index-test.js

-      </Hds::AppHeader>
-    `);
+  test('it renders content passed into the globalActions and utilityActions named blocks', async function (assert) {
+    await render(hbs`<Hds::AppHeader>


[nitpick] can you check if the test files should be reformatted? I see a strange indentation here.

Hmm... I checked and it seems like the linter wants it to be indented like this ¯_(ツ)_/¯

showcase/app/templates/layouts/app-frame/index.hbs

showcase/app/components/mock/app/sidebar/side-nav.gts

showcase/app/components/mock/app/index.gts

showcase/app/components/mock/app/sidebar/app-side-nav.gts

github-actions · 2025-04-25T15:46:31Z

📦 RC Packages Published

Latest commit: a2bd870

Published 1 packages

@hashicorp/[email protected]

yarn up -C @hashicorp/design-system-components@rc

dchyun

Looking good! Just had a nit and one docs question.

packages/components/src/components.ts

website/docs/components/side-nav/partials/code/how-to-use.md

didoo

👍

hashibot-hds added packages/components docs-website Content updates to the documentation website labels Apr 22, 2025

vercel bot deployed to Preview – hds-website April 22, 2025 16:03 View deployment

vercel bot deployed to Preview – hds-showcase April 22, 2025 16:07 View deployment

vercel bot deployed to Preview – hds-website April 22, 2025 16:09 View deployment

hashibot-hds added the showcase label Apr 22, 2025

vercel bot deployed to Preview – hds-showcase April 22, 2025 16:13 View deployment

vercel bot deployed to Preview – hds-website April 22, 2025 16:16 View deployment

shleewhite marked this pull request as ready for review April 22, 2025 18:22

shleewhite requested review from a team as code owners April 22, 2025 18:22

didoo reviewed Apr 23, 2025

View reviewed changes

packages/components/src/components/hds/side-nav/index.ts Show resolved Hide resolved

.changeset/real-yaks-press.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview – hds-showcase April 23, 2025 21:57 View deployment

vercel bot deployed to Preview – hds-website April 23, 2025 21:59 View deployment

vercel bot deployed to Preview – hds-showcase April 23, 2025 22:05 View deployment

vercel bot deployed to Preview – hds-website April 23, 2025 22:07 View deployment

vercel bot deployed to Preview – hds-showcase April 24, 2025 16:04 View deployment

vercel bot deployed to Preview – hds-website April 24, 2025 16:06 View deployment

shleewhite requested review from a team and didoo April 24, 2025 18:20

didoo previously approved these changes Apr 24, 2025

View reviewed changes

didoo mentioned this pull request Apr 25, 2025

AdvancedTable - AppFrame followup #2822

Merged

1 task

shleewhite dismissed didoo’s stale review via c49d6ad April 25, 2025 14:05

shleewhite added 7 commits April 25, 2025 11:28

fix: include enterprise nav css in exported styles

ccf6ca8

feat: add AppSideNav to exported components

ffcbde4

feat: update AppFrame examples to use AppSideNav

dbdc6dd

fix: showcase linting errors

0773339

fix: remove unneeded app frame example

3407aff

fix: incorporate feedback

0f88e44

fix: enable percy for AppSideNav

641c8ff

shleewhite force-pushed the hds-4777/revive-enterprise-nav branch from 68e6ec1 to 641c8ff Compare April 25, 2025 15:28

vercel bot deployed to Preview – hds-showcase April 25, 2025 15:30 View deployment

vercel bot deployed to Preview – hds-website April 25, 2025 15:35 View deployment

shleewhite added the release-candidate Publishes release candidates to npm label Apr 25, 2025

dchyun reviewed Apr 25, 2025

View reviewed changes

packages/components/src/components.ts Show resolved Hide resolved

website/docs/components/side-nav/partials/code/how-to-use.md Outdated Show resolved Hide resolved

chore: alphabetize

a2bd870

vercel bot deployed to Preview – hds-showcase April 25, 2025 20:17 View deployment

shleewhite removed the release-candidate Publishes release candidates to npm label Apr 25, 2025

vercel bot deployed to Preview – hds-website April 25, 2025 20:20 View deployment

chore: revert changes to website

53f7c3d

vercel bot deployed to Preview – hds-showcase April 25, 2025 20:57 View deployment

revert changes to website again

6823bcd

hashibot-hds removed the docs-website Content updates to the documentation website label Apr 25, 2025

vercel bot deployed to Preview – hds-showcase April 25, 2025 21:00 View deployment

vercel bot deployed to Preview – hds-website April 25, 2025 21:03 View deployment

shleewhite requested a review from dchyun April 28, 2025 14:22

didoo approved these changes Apr 28, 2025

View reviewed changes

dchyun approved these changes Apr 28, 2025

View reviewed changes

shleewhite merged commit c2d6888 into main Apr 28, 2025
16 checks passed

shleewhite deleted the hds-4777/revive-enterprise-nav branch April 28, 2025 14:36

hashibot-hds mentioned this pull request Apr 28, 2025

Version Packages #2829

Merged

alex-ju added this to the [email protected] milestone May 7, 2025

Revive Enterprise Nav components #2837

Revive Enterprise Nav components #2837

Uh oh!

Conversation

shleewhite commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Summary

🔗 External links

👀 Component checklist

Uh oh!

vercel bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shleewhite commented Apr 22, 2025

Uh oh!

didoo commented Apr 22, 2025

Uh oh!

shleewhite commented Apr 22, 2025

Uh oh!

didoo commented Apr 22, 2025

Uh oh!

Uh oh!

Uh oh!

didoo commented Apr 24, 2025

Uh oh!

didoo commented Apr 24, 2025

Uh oh!

didoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

didoo Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

shleewhite Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 RC Packages Published

@hashicorp/[email protected]

Uh oh!

dchyun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

didoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shleewhite commented Apr 22, 2025 •

edited

Loading

vercel bot commented Apr 22, 2025 •

edited

Loading

didoo left a comment •

edited

Loading

github-actions bot commented Apr 25, 2025 •

edited

Loading