Hds::Modal – Prevent onClose callback function invocation when isDismissDisabled is true
#1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent invoking the callback function if `isDismissDisabled` is true
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashibot-hds
added
docs-website
didoo
approved these changes
Jun 28, 2023
Co-authored-by: Cristiano Rastelli <[email protected]>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Hds::Modal– PreventonClosecallback function invocation whenisDismissDisabledistrue🛠️ Detailed description
isDismissDisabledwas introduced in the Modal component, based on ambassadors' feedback/request, as a method of preventing data loss in forms. In practice, this argument and the suggested implementation were never used for such a case.Recent feedback from HCP Packer and Hermes flags that their expectation is that the
onClosecallback function is not invoked whenisDismissDisabledistrue, so we're updating the code to match this consumer expectation.🔗 External links
Jira ticket: HDS-2146
👀 Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.