Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HDS/Flight Icon packages #321

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update HDS/Flight Icon packages #321

merged 2 commits into from
Sep 5, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Sep 5, 2023

Updates the HDS packages.

On the design-system-components side, we gain a fix to the modal's isDismissedDisabled argument: Users will no longer be able to dismiss modals while the primary task is running (hashicorp/design-system#1456). In FlightIcon world, we now have the Jira logo.

I did a pretty thorough clickthrough and caught only 1 visual diff. It looks like there's a collision between HDS's and our "tooltip.scss" files, so I renamed ours to x-tooltip.scss.

@jeffdaley jeffdaley requested a review from a team as a code owner September 5, 2023 14:02
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@jeffdaley jeffdaley merged commit c4b98e5 into main Sep 5, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/update-hds branch September 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants