Backport of NET-6821 Disable Terminating Gateway Auto Host Header Rewrite into release/1.18.x#20834
Merged
sarahalsmiller merged 7 commits intorelease/1.18.xfrom Apr 26, 2024
Conversation
e451412 to
98aef5d
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 12, 2024
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
…ite/evenly-lucky-donkey
| name: 'DisableAutoHostRewrite', | ||
| type: 'bool: ""', | ||
| description: | ||
| 'When set to true, Terminating Gateway will not modify the incoming requests host header for this service.', |
Member
There was a problem hiding this comment.
Suggested change
| 'When set to true, Terminating Gateway will not modify the incoming requests host header for this service.', | |
| 'When set to true, Terminating Gateway will not modify the incoming requests host header for this service. Available in Consul v1.18.1 or later.', |
Contributor
|
@sarahalsmiller Looks like this still is outstanding as a backport for 1.18.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20802 to be assessed for backporting due to the inclusion of the label backport/1.18.
The below text is copied from the body of the original PR.
Description
Testing & Reproduction steps
Observe the generated XDS and note that the default behavior is to auto host rewrite, but not when DisableAutoHostRewrite is set to true.
Links
PR Checklist
Overview of commits