NET-6821 Disable Terminating Gateway Auto Host Header Rewrite#20802
NET-6821 Disable Terminating Gateway Auto Host Header Rewrite#20802sarahalsmiller merged 6 commits intomainfrom
Conversation
| CAFile: svc.CAFile, | ||
| SNI: svc.SNI, | ||
| ServiceKind: kind, | ||
| AutoHostRewrite: !svc.DisableAutoHostRewrite, |
There was a problem hiding this comment.
My logic here is that by making this a flag you have to set to true it won't change any existing behavior in existing terminating gateway setups.
boruszak
left a comment
There was a problem hiding this comment.
I reviewed the edits to terminating-gateway.mdx and left one suggestion.
Approving on behalf of consul-docs.
|
@sarahalsmiller Will an accompanying PR to update CRDs also follow? Looking forward this PR being merged! |
Yes it will. In my experience its just easier to wait until the original PR merges into core so you don't accidentally point the go.mod file at a commit that doesn't exist in main. |
c86b043 to
4abaa66
Compare
website/content/docs/connect/config-entries/terminating-gateway.mdx
Outdated
Show resolved
Hide resolved
f47ad0c to
7eeb594
Compare
missylbytes
left a comment
There was a problem hiding this comment.
LGTM when all tests pass
b46aa0e to
11e4a74
Compare
Description
Testing & Reproduction steps
Observe the generated XDS and note that the default behavior is to auto host rewrite, but not when DisableAutoHostRewrite is set to true.
Links
PR Checklist