Skip to content

Backport of catalog: add metadata filtering to refine workload selectors into release/1.17.x#19203

Closed
hc-github-team-consul-core wants to merge 1 commit intorelease/1.17.xfrom
backport/rboyer/v2-service-filtering/hopefully-smiling-bluejay
Closed

Backport of catalog: add metadata filtering to refine workload selectors into release/1.17.x#19203
hc-github-team-consul-core wants to merge 1 commit intorelease/1.17.xfrom
backport/rboyer/v2-service-filtering/hopefully-smiling-bluejay

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19198 to be assessed for backporting due to the inclusion of the label backport/1.17.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@rboyer
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

This implements the Filter field on pbcatalog.WorkloadSelector to be a post-fetch in-memory filter using the https://github.com/hashicorp/go-bexpr expression language to filter resources based on their envelope metadata fields.

All existing usages of WorkloadSelector should be able to make use of the filter.

NET-5696


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/rboyer/v2-service-filtering/hopefully-smiling-bluejay branch from f448a06 to 5c95465 Compare October 13, 2023 18:38
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/rboyer/v2-service-filtering/hopefully-smiling-bluejay branch from 5c95465 to f448a06 Compare October 13, 2023 18:38
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@rboyer rboyer closed this Oct 13, 2023
@rboyer rboyer deleted the backport/rboyer/v2-service-filtering/hopefully-smiling-bluejay branch October 13, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants