Backport of cli: remove stray whitespace when loading the consul version from the VERSION file into release/1.13.x#17520
Merged
hc-github-team-consul-core merged 1 commit intorelease/1.13.xfrom May 30, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/remove-trailing-whitespace-in-version-file/literally-becoming-porpoise
branch
2 times, most recently
from
4bb9eb1 to
1e9047c
Compare
github-team-consul-core-pr-approver
approved these changes
May 30, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
hc-github-team-consul-core
deleted the
backport/remove-trailing-whitespace-in-version-file/literally-becoming-porpoise
branch
Member
|
Note for posterity: the original fix was merged just before the bug was introduced in |
nathancoleman
added a commit
to hashicorp/consul-api-gateway
that referenced
this pull request
Jun 20, 2023
1.13.8 has a known issue preventing the tests from running due to a missed backport. That backport has since been completed in hashicorp/consul#17520
nathancoleman
added a commit
to hashicorp/consul-api-gateway
that referenced
this pull request
Jun 20, 2023
* Update conformance testing matrix for Consul 1.15 * Add Consul 1.16 to conformance testing matrix * Disable management of external CRDs for consul-k8s>=1.2.0 * Update Consul version pins for CI * Add Consul 1.16 version to CI testing matrix * Restore Consul 1.13.7 to testing matrix 1.13.8 has a known issue preventing the tests from running due to a missed backport. That backport has since been completed in hashicorp/consul#17520
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16467 to be assessed for backporting due to the inclusion of the label backport/1.13.
The below text is copied from the body of the original PR.
Fixes a regression from #15631 in the output of
consul versionfrom:to
Overview of commits