Skip to content

[HCP Observability] Turn off retries for now until dynamically configurable #17496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Achooo merged 2 commits into from
May 29, 2023
Merged

[HCP Observability] Turn off retries for now until dynamically configurable #17496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ac3c53
Remove retries for now until dynamic configuration is possible
Achooo May 26, 2023
a84594f
Clarify comment
Achooo May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions agent/hcp/client/metrics_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ const (
defaultStreamTimeout = 15 * time.Second

// Retry config
// TODO: Evenutally, we'd like to configure these values dynamically.
// TODO: Eventually, we'd like to configure these values dynamically.
defaultRetryWaitMin = 1 * time.Second
defaultRetryWaitMax = 15 * time.Second
defaultRetryMax = 4
// defaultRetryMax is set to 0 to turn off retry functionality, until dynamic configuration is possible.
// This is to circumvent any spikes in load that may cause or exacerbate server-side issues for now.
defaultRetryMax = 0
)

// MetricsClient exports Consul metrics in OTLP format to the HCP Telemetry Gateway.
Expand Down