Backport of Upgrade test target image into release/1.15.x#17239
Merged
huikang merged 1 commit intorelease/1.15.xfrom May 8, 2023
Merged
Conversation
hc-github-team-consul-core
force-pushed
the
backport/upgrade-test-targetImage/immensely-relative-clam
branch
2 times, most recently
from
d0001d8 to
4fd91e8
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
May 8, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
huikang
approved these changes
May 8, 2023
huikang
force-pushed
the
backport/upgrade-test-targetImage/immensely-relative-clam
branch
from
306f744 to
1a3365a
Compare
huikang
deleted the
backport/upgrade-test-targetImage/immensely-relative-clam
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17226 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
Split from #17186
Change to upgrade test
cluster.StandardUpgrade(utils.GetTargetImageName(), tc.targetVersion), because the image we upgrade to isconsul:locally, which is built locally in the CI runner. This image name may be different from the latest imagedocker.mirror.hashicorp.services/docker:1.15for example.test/integration/consul-container/test/upgrade/fullstopupgrade_test.gothat always true when an error is expected. (the second commit in the PR)Links
PR Checklist
Overview of commits