Conversation
huikang
added
backport/1.15
huikang
force-pushed
the
upgrade-test-targetImage
branch
from
43a0088 to
77f866d
Compare
- the image name of latest version and target version could be different. Add the parameter of targetImage to the upgrade function
huikang
force-pushed
the
upgrade-test-targetImage
branch
from
77f866d to
d194d8d
Compare
4 tasks
loshz
approved these changes
May 8, 2023
Contributor
loshz
left a comment
loshz
left a comment
There was a problem hiding this comment.
LGTM - I added 1.13/1.14 backport labels, but feel free to remove them if this change will only affect 1.15 and above.
This was referenced May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split from #17186
Change to upgrade test
cluster.StandardUpgrade(utils.GetTargetImageName(), tc.targetVersion), because the image we upgrade to isconsul:locally, which is built locally in the CI runner. This image name may be different from the latest imagedocker.mirror.hashicorp.services/docker:1.15for example.test/integration/consul-container/test/upgrade/fullstopupgrade_test.gothat always true when an error is expected. (the second commit in the PR)Links
PR Checklist