Merged
Conversation
4 tasks
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
8df2523 to
2d0117d
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
da5a915 to
93c345a
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
4 times, most recently
from
48a1413 to
b5f62c4
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
93c345a to
38ea96b
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
38ea96b to
b64a0bf
Compare
boxofrad
reviewed
May 5, 2023
internal/catalog/internal/controllers/common/dependency_mappers.go
Outdated
Show resolved
Hide resolved
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
b5f62c4 to
6749521
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
b64a0bf to
00bf64b
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
fba2cd5 to
7278e65
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
3 times, most recently
from
a66a7e5 to
b9ed172
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
115eb1c to
eb448ec
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
b9ed172 to
d702cad
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
eb448ec to
b6acdf7
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
d702cad to
c6bae49
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
a559ba6 to
92d2ee7
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
c6bae49 to
16fcab1
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
1d4d75f to
ee51506
Compare
ishustava
approved these changes
May 9, 2023
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
LGTM. I left a few minor comments.
internal/catalog/internal/controllers/nodehealth/controller_test.go
Outdated
Show resolved
Hide resolved
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
ee51506 to
d1437c3
Compare
ishustava
reviewed
May 9, 2023
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
d1437c3 to
2d58a6c
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
16fcab1 to
9594a10
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
f6e07da to
8a6ebb9
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
9594a10 to
17ee0be
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
8a6ebb9 to
d661adf
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
2 times, most recently
from
55585af to
3643c1d
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
d661adf to
b206d95
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
3 times, most recently
from
b6f86ee to
8d05b6c
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
b58240e to
e2d93b9
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
8d05b6c to
7b55777
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
e2d93b9 to
540a15f
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
7b55777 to
9f56985
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
540a15f to
da72b6c
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
9f56985 to
4a88416
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
da72b6c to
32cde93
Compare
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
4a88416 to
7eb038c
Compare
This will aggregate all HealthStatus objects owned by the Node and update the status of the Node with an overall health.
mkeeler
force-pushed
the
catalog-v2/node-health-controller
branch
from
7eb038c to
34924a7
Compare
mkeeler
added
pr/no-backport
pr/no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This controller will monitor HealthStatus objects owned by Nodes and report aggregate health information in the Status of a Node.
This builds on PR #17211. I did have to also squash merge the boxofrad/controller-implementation branch. Eventually that should be removed from this PR once it is merged. For now you can just look at the second non-squashed commit.
Testing & Reproduction steps
Unit tests are complete with 93.5% coverage. The uncovered lines shouldn't really be possible.
Multi-controller lifecycle integration test will come in a future PR.
PR Checklist