Add type validations for the Catalog resources#17211
Merged
Conversation
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
4fee3e3 to
30919e4
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
d89180b to
b8affa4
Compare
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
30919e4 to
8055a29
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
b8affa4 to
8df2523
Compare
mkeeler
commented
May 3, 2023
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
8055a29 to
1501a2a
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
2d0117d to
78c67c4
Compare
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
1501a2a to
c44fbc7
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
78c67c4 to
d95bcf1
Compare
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
f272939 to
b57fa58
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
d95bcf1 to
48a1413
Compare
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
b57fa58 to
d1710e2
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
48a1413 to
b5f62c4
Compare
boxofrad
reviewed
May 5, 2023
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
d1710e2 to
cafd8b8
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
6749521 to
fba2cd5
Compare
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
2 times, most recently
from
15742db to
359200a
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
fba2cd5 to
7278e65
Compare
mkeeler
added
pr/no-changelog
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
7278e65 to
115eb1c
Compare
mkeeler
force-pushed
the
catalog-v2/type-registry
branch
from
359200a to
c8cbe41
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
115eb1c to
eb448ec
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
a559ba6 to
92d2ee7
Compare
ishustava
reviewed
May 9, 2023
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
This looks awesome 😃 I love all the error types, and the tests are amazing!
I left a few questions and suggestions in-line. Let me know what you think!
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
4 times, most recently
from
d1437c3 to
2d58a6c
Compare
boxofrad
reviewed
May 10, 2023
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
3 times, most recently
from
8a6ebb9 to
d661adf
Compare
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
b206d95 to
b58240e
Compare
analogue
reviewed
May 10, 2023
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
b58240e to
e2d93b9
Compare
analogue
reviewed
May 11, 2023
analogue
reviewed
May 11, 2023
analogue
reviewed
May 11, 2023
analogue
reviewed
May 11, 2023
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
2 times, most recently
from
540a15f to
da72b6c
Compare
Also adding some common resource validation error types to the internal/resource package.
mkeeler
force-pushed
the
catalog-v2/type-validations
branch
from
da72b6c to
32cde93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds type validations for all the new catalog resources. This builds off the types defined in #17124 and adds custom validation hooks for the resource service to invoke for all of them.
Additionally the workload type also got a mutation hook to fill out the Identity field of that resource if not present.
Testing & Reproduction steps
Testing involved writing the suite of unit tests - 100% code coverage. Things are working as expected but that doesn't mean I missed validating some condition I hadn't thought of.
PR Checklist