Backport of APIGW: Update how status conditions for certificates are handled into release/1.15.x#17170
Merged
sarahalsmiller merged 3 commits intorelease/1.15.xfrom Jun 22, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit
branch
from
f048d35 to
ad98357
Compare
hc-github-team-consul-core
force-pushed
the
backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit
branch
from
ad98357 to
f048d35
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
Apr 27, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
sarahalsmiller
force-pushed
the
backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit
branch
from
8d81538 to
ab4890c
Compare
nathancoleman
force-pushed
the
backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit
branch
from
ab4890c to
efee5ee
Compare
sarahalsmiller
deleted the
backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17115 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
This changes how status conditions for invalid certifcates on listeners are reported so that the status condition is on the listener and mentions which certificate is invalid in the message.
Testing & Reproduction steps
Run unit tests
Links
N/A
PR Checklist
Overview of commits