Backport of feat(ingress gateway: support configuring limits in ingress-gateway c… into release/1.11.x#14789
Merged
huikang merged 2 commits intorelease/1.11.xfrom Oct 15, 2022
Conversation
ed5b245 to
489d2aa
Compare
3414f39 to
f4278e5
Compare
…ss-gateway c… into release/1.12.x (#14790) * feat(ingress gateway: support configuring limits in ingress-gateway c… (#14749) * feat(ingress gateway: support configuring limits in ingress-gateway config entry - a new Defaults field with max_connections, max_pending_connections, max_requests is added to ingress gateway config entry - new field max_connections, max_pending_connections, max_requests in individual services to overwrite the value in Default - added unit test and integration test - updated doc Co-authored-by: Chris S. Kim <ckim@hashicorp.com> Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> Co-authored-by: Dan Stough <dan.stough@hashicorp.com>
f4278e5 to
c14c56f
Compare
7b2c446 to
c34d9f4
Compare
huikang
approved these changes
Oct 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14749 to be assessed for backporting due to the inclusion of the label backport/1.11.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
As a user of ingress gateway, I want to increase the max_connections of the service in the ingress-gateway config entry (link to the detailed description). However, in current implementation, max_coonections can’t be changed and is set to the default value of 1024 by envoy.
This PR adds a new field named Defaults to the ingress-gateway config entry and
max_xyzto individual listening services. The new fields allow user to configure themax_xyzof the upstream cluster of a specified service behind the ingress gateway.Testing & Reproduction steps
test/integration/connect/envoy/case-ingress-gateway-multiple-services/config_entries.hcl).Links
Address #13374
Supersede #14708
Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.
PR Checklist
Overview of commits