feat(ingress gateway): configure max_connections to upstream service#14708
Closed
feat(ingress gateway): configure max_connections to upstream service#14708
Conversation
- added unit test - updated doc
6fecacb to
a45cebe
Compare
a45cebe to
208a622
Compare
kisunji
reviewed
Sep 22, 2022
Contributor
kisunji
left a comment
There was a problem hiding this comment.
This looks okay to me but will tag other members for review since I'm not too familiar with ingress gw code
Co-authored-by: Chris S. Kim <ckim@hashicorp.com>
huikang
commented
Sep 22, 2022
| MaxConnections: makeUint32Value(int(svc.MaxConnections)), | ||
| }, | ||
| } | ||
| } else { |
Collaborator
Author
There was a problem hiding this comment.
Actually the else branch will never happen because
* The Proxy.Upstreams configuration is invalid for a ingress-gateway
Leave it here for safety check.
boruszak
approved these changes
Sep 22, 2022
Contributor
boruszak
left a comment
There was a problem hiding this comment.
I reviewed the docs in this PR, 14708.txt and ingress-gateway.mdx, only. I have one suggestion, but I was unsure of your intent. Please review my comment below, and let me know if you have any questions or need additional assistance.
Approving on behalf of consul-docs.
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
This reverts commit 8c0dcae.
3 tasks
Collaborator
Author
|
superseded by #14749 |
This was referenced Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a user of ingress gateway, I want to increase the max_connections of the service in the ingress-gateway config entry (link to the detailed description). However, in current implementation, max_coonections can’t be changed and set to the default value of 1024 by envoy.
This PR adds a new field named MaxConnections to the service field of ingress-gateway config entry. The new field allows user to configure the max_connections of the upstream cluster of a specified service behind the ingress gateway.
Testing & Reproduction steps
Links
Address #13374
Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.
PR Checklist