[1.3.4] Remove Duplicate UBI Tags (#3265)#3860
Merged
kisunji merged 2 commits intorelease/1.3.4from Apr 3, 2024
Merged
Conversation
- Amalgamate UBI with Dockerhub and Redhat tags into one step - Avoids a production incident that errors on duplicate tags: hashicorp/releng-support#123
kisunji
added
pr/no-changelog
zalimeni
changed the title
zalimeni
approved these changes
Apr 3, 2024
Member
zalimeni
left a comment
zalimeni
left a comment
There was a problem hiding this comment.
LGTM other than the get-go-version missing. I also updated the PR title since this is a point release backport and we'll want to make sure we don't forget .x as well.
If needed, we can add back the Dockerhub dev tags missing for FIPS builds in a separate PR and backport all the way down.
.github/workflows/build.yml
Outdated
| needs: [get-product-version, get-go-version, build] | ||
| build-docker-ubi: | ||
| name: Docker ${{ matrix.arch }} ${{ matrix.fips }} UBI builds | ||
| needs: [get-product-version, build] |
Member
There was a problem hiding this comment.
I think we still need get-go-version here as a dependency due to the extra_build_args that relies on it
2 tasks
kisunji
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Prerelease 1.3.4 * [prerelease-1.3.4] Disable CE test (#3827) * [1.3.4] Disable all CE tests (#3835) Disable CE tests on all workflows * Backport of [NET-8601] Upgrade `vault/api` and `docker/docker` to resolve open CVEs into release/1.3.4 (#3843) * backport of commit 1711f31 * backport of commit 9049c0d * backport of commit cacd09b * [1.3.4] Remove Duplicate UBI Tags (#3265) (#3860) --------- Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist