Skip to content

Remove Duplicate UBI Tags#3265

Merged
emilymianeil merged 1 commit intomainfrom
releng/remove-duplicate-ubi
Nov 28, 2023
Merged

Remove Duplicate UBI Tags#3265
emilymianeil merged 1 commit intomainfrom
releng/remove-duplicate-ubi

Conversation

@emilymianeil
Copy link
Copy Markdown
Contributor

This PR is intended to avoid a production incident where there are duplicate tags (auto-assigned) to UBI images. The entire issue is described here, and can be avoided by building UBIs (intended for both Dockerhub and Redhat) in one step.

PR Checklist

  • appropriate backport labels added
  • not a security concern

- Amalgamate UBI with Dockerhub and Redhat tags into one step
- Avoids a production incident that errors on duplicate tags:
hashicorp/releng-support#123
@emilymianeil emilymianeil added backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. labels Nov 27, 2023
@emilymianeil emilymianeil marked this pull request as ready for review November 27, 2023 18:24
@curtbushko curtbushko added the pr/no-changelog PR does not need a corresponding .changelog entry label Nov 27, 2023
Copy link
Copy Markdown
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emily! This looks correct to me.

@emilymianeil emilymianeil merged commit a8857ea into main Nov 28, 2023
@emilymianeil emilymianeil deleted the releng/remove-duplicate-ubi branch November 28, 2023 19:29
jm96441n pushed a commit that referenced this pull request Nov 29, 2023
- Amalgamate UBI with Dockerhub and Redhat tags into one step
- Avoids a production incident that errors on duplicate tags:
hashicorp/releng-support#123
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
- Amalgamate UBI with Dockerhub and Redhat tags into one step
- Avoids a production incident that errors on duplicate tags:
hashicorp/releng-support#123
@kisunji kisunji added backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. and removed backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. labels Apr 3, 2024
kisunji pushed a commit that referenced this pull request Apr 3, 2024
- Amalgamate UBI with Dockerhub and Redhat tags into one step
- Avoids a production incident that errors on duplicate tags:
hashicorp/releng-support#123
kisunji pushed a commit that referenced this pull request Apr 3, 2024
- Amalgamate UBI with Dockerhub and Redhat tags into one step
- Avoids a production incident that errors on duplicate tags:
hashicorp/releng-support#123
kisunji pushed a commit that referenced this pull request Apr 3, 2024
Remove Duplicate UBI Tags (#3265)

- Amalgamate UBI with Dockerhub and Redhat tags into one step
- Avoids a production incident that errors on duplicate tags:
hashicorp/releng-support#123

Co-authored-by: emily neil <63985869+emilymianeil@users.noreply.github.com>
kisunji pushed a commit that referenced this pull request Apr 3, 2024
kisunji pushed a commit that referenced this pull request Apr 3, 2024
* Prerelease 1.3.4

* [prerelease-1.3.4] Disable CE test (#3827)

* [1.3.4] Disable all CE tests (#3835)

Disable CE tests on all workflows

* Backport of [NET-8601] Upgrade `vault/api` and `docker/docker` to resolve open CVEs into release/1.3.4 (#3843)

* backport of commit 1711f31

* backport of commit 9049c0d

* backport of commit cacd09b

* [1.3.4] Remove Duplicate UBI Tags (#3265) (#3860)

---------

Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
kisunji pushed a commit that referenced this pull request Apr 3, 2024
* Prerelease 1.2.7

* [prerelease-1.2.7] Disable CE test (#3826)

* [1.2.7] Disable all CE tests (#3834)

Disable CE tests on all workflows

* Backport of [NET-8601] Upgrade `vault/api` and `docker/docker` to resolve open CVEs into release/1.2.7 (#3844)

* backport of commit 1711f31

* backport of commit 9049c0d

* backport of commit cacd09b

* [1.2.7] Remove Duplicate UBI Tags (#3265) (#3859)

Remove Duplicate UBI Tags (#3265)

- Amalgamate UBI with Dockerhub and Redhat tags into one step
- Avoids a production incident that errors on duplicate tags:
hashicorp/releng-support#123

Co-authored-by: emily neil <63985869+emilymianeil@users.noreply.github.com>

* Re-add get-go-version (#3863)

---------

Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
Co-authored-by: emily neil <63985869+emilymianeil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants