Skip to content

Backport of CRT build failing for Go into release/1.2.x#3497

Merged
curtbushko merged 2 commits intorelease/1.2.xfrom
backport/curtbushko/fix-crt-build-to-release-1.2.x
Jan 22, 2024
Merged

Backport of CRT build failing for Go into release/1.2.x#3497
curtbushko merged 2 commits intorelease/1.2.xfrom
backport/curtbushko/fix-crt-build-to-release-1.2.x

Conversation

@curtbushko
Copy link
Copy Markdown
Contributor

@curtbushko curtbushko commented Jan 22, 2024

Changes proposed in this PR

  • Manual backport of CRT build failing for Go #3490 into release/1.2.x
  • added in a dockerfile change that was breaking CRT on main instead of doing a separate PR.

How I've tested this PR

CI

How I expect reviewers to test this PR

👀

Checklist

@curtbushko curtbushko added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jan 22, 2024
@curtbushko curtbushko self-assigned this Jan 22, 2024
@curtbushko curtbushko changed the title CRT build failing for Go (#3490) Backport of CRT build failing for Go into release/1.2.x Jan 22, 2024
@curtbushko curtbushko marked this pull request as ready for review January 22, 2024 19:38
@curtbushko curtbushko merged commit d67c990 into release/1.2.x Jan 22, 2024
@curtbushko curtbushko deleted the backport/curtbushko/fix-crt-build-to-release-1.2.x branch January 22, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants