Skip to content

CRT build failing for Go#3490

Merged
curtbushko merged 1 commit intomainfrom
curtbushko/fix-crt-build
Jan 19, 2024
Merged

CRT build failing for Go#3490
curtbushko merged 1 commit intomainfrom
curtbushko/fix-crt-build

Conversation

@curtbushko
Copy link
Copy Markdown
Contributor

Changes proposed in this PR

  • CRT builds were failing as they only build after something is merged

How I've tested this PR

  • Unfortunately this needs to be merged in order to work

How I expect reviewers to test this PR

Checklist

@curtbushko curtbushko added backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. labels Jan 19, 2024
@curtbushko curtbushko merged commit 20a2397 into main Jan 19, 2024
@curtbushko curtbushko deleted the curtbushko/fix-crt-build branch January 19, 2024 22:05
curtbushko added a commit that referenced this pull request Jan 22, 2024
curtbushko added a commit that referenced this pull request Jan 22, 2024
curtbushko added a commit that referenced this pull request Jan 22, 2024
curtbushko added a commit that referenced this pull request Jan 22, 2024
* CRT build failing for Go (#3490)
* use alpine tag for godiscover build
curtbushko added a commit that referenced this pull request Jan 22, 2024
* CRT build failing for Go (#3490)
* use alpine tag for godiscover build
curtbushko added a commit that referenced this pull request Jan 22, 2024
* CRT build failing for Go (#3490)
* use alpine tag for godiscover build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants