Backport of Fix ENT Tests Now that They Are Running Again 🏃 into release/1.0.x#3090
Merged
zalimeni merged 1 commit intorelease/1.0.xfrom Oct 17, 2023
Merged
Conversation
test: fix tests that are failing on main
zalimeni
added
pr/no-changelog
nathancoleman
approved these changes
Oct 17, 2023
Member
nathancoleman
left a comment
nathancoleman
left a comment
There was a problem hiding this comment.
LGTM. We do technically support this version for another couple of weeks. Thanks for backporting!
Member
Author
@nathancoleman sure thing! Ran into failures in another PR and realized I needed this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is manually generated from #3077 to be assessed for backporting.
The below text is copied from the body of the original PR.
ENT tests were just turned back on in CI. This revealed some failing test cases. This PR attempts to get everything in working order.