Manual backport of [NET-5944] security: Upgrade Go and x/net into release/1.0.x#3089
Merged
zalimeni merged 1 commit intorelease/1.0.xfrom Oct 17, 2023
Conversation
zalimeni
added
the
pr/no-backport
Member
Author
|
Attempting fix for unit tests via backport of recent fix: #3090 |
zalimeni
changed the base branch from
release/1.0.x
to
backport/1.0.x/dans/fix-enterprise-flakes
zalimeni
force-pushed
the
backport/zalimeni/net-5944-go-update-1.20.10/manual-1.0.x
branch
from
4ecacc5 to
2f6661b
Compare
curtbushko
reviewed
Oct 17, 2023
Contributor
curtbushko
left a comment
curtbushko
left a comment
There was a problem hiding this comment.
The go update looks ok but is that ent unit test flaking?
Member
Author
@curtbushko yep, it is. Once I noticed that, I opened #3090 expecting that backport to resolve it - assuming that works (that PR's tests are passing), will rebase here and look for a clean run. |
curtbushko
approved these changes
Oct 17, 2023
Base automatically changed from
backport/1.0.x/dans/fix-enterprise-flakes
to
release/1.0.x
October 17, 2023 14:26
zalimeni
force-pushed
the
backport/zalimeni/net-5944-go-update-1.20.10/manual-1.0.x
branch
from
2f6661b to
dc956eb
Compare
zalimeni
deleted the
backport/zalimeni/net-5944-go-update-1.20.10/manual-1.0.x
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #3085, resolves #3086.
Note that Go 1.19 is now EOL, so for the final release of
1.0.x, we're moving to Go 1.20.